Merge pull request #74 from ConductorOne/bt/dont_ignore_not_found_in_list

btipling · web-flow · commit 7456c3069d75 · 2025-05-29T16:18:31.000-07:00
[BB-813] INC-231 404's from List should not be ignored
diff --git a/pkg/connector/team.go b/pkg/connector/team.go
@@ -106,9 +106,6 @@ func (o *teamResourceType) List(ctx context.Context, parentID *v2.ResourceId, pt
 	for _, team := range teams {
 		fullTeam, _, err := o.client.Teams.GetTeamByID(ctx, orgID, team.GetID()) //nolint:staticcheck // TODO: migrate to GetTeamBySlug
 		if err != nil {
-			if isNotFoundError(resp) {
-				return nil, "", nil, uhttp.WrapErrors(codes.NotFound, fmt.Sprintf("team: %d not found", team.GetID()))
-			}
 			return nil, "", nil, err
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -106,9 +106,6 @@ func (o teamResourceType) List(ctx context.Context, parentID v2.ResourceId, pt`
`106`	`106`	`for _, team := range teams {`
`107`	`107`	`fullTeam, _, err := o.client.Teams.GetTeamByID(ctx, orgID, team.GetID()) //nolint:staticcheck // TODO: migrate to GetTeamBySlug`
`108`	`108`	`if err != nil {`
`109`		`- if isNotFoundError(resp) {`
`110`		`- return nil, "", nil, uhttp.WrapErrors(codes.NotFound, fmt.Sprintf("team: %d not found", team.GetID()))`
`111`		`- }`
`112`	`109`	`return nil, "", nil, err`
`113`	`110`	`}`
`114`	`111`