Fix possible nil pointer dereference if res is nil. (#38)

ggreer · web-flow · commit 799c9bb1571a · 2024-07-17T10:09:59.000-07:00
diff --git a/pkg/connector/user.go b/pkg/connector/user.go
@@ -151,7 +151,7 @@ func (o *userResourceType) List(ctx context.Context, parentID *v2.ResourceId, pt
 		u, res, err := o.client.Users.GetByID(ctx, user.GetID())
 		if err != nil {
 			// This undocumented API can return 404 for some users. If this fails it means we won't get some of their details like email
-			if res.StatusCode != http.StatusNotFound {
+			if res == nil || res.StatusCode != http.StatusNotFound {
 				return nil, "", nil, err
 			}
 			l.Error("error fetching user by id", zap.Error(err), zap.Int64("user_id", user.GetID()))

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ func (o userResourceType) List(ctx context.Context, parentID v2.ResourceId, pt`
`151`	`151`	`u, res, err := o.client.Users.GetByID(ctx, user.GetID())`
`152`	`152`	`if err != nil {`
`153`	`153`	`// This undocumented API can return 404 for some users. If this fails it means we won't get some of their details like email`
`154`		`- if res.StatusCode != http.StatusNotFound {`
	`154`	`+ if res == nil \|\| res.StatusCode != http.StatusNotFound {`
`155`	`155`	`return nil, "", nil, err`
`156`	`156`	`}`
`157`	`157`	`l.Error("error fetching user by id", zap.Error(err), zap.Int64("user_id", user.GetID()))`