Skip to content

Commit a945605

Browse files
committed
more
1 parent c8c344e commit a945605

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

pkg/connector/enterprise_role.go

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -135,27 +135,19 @@ func (o *enterpriseRoleResourceType) Grants(
135135
return nil, "", nil, fmt.Errorf("baton-github: error getting user roles cache: %w", err)
136136
}
137137

138-
var (
139-
annotations annotations.Annotations
140-
ret = make([]*v2.Grant, 0, len(cache[resource.Id.Resource]))
141-
)
138+
ret := []*v2.Grant{}
142139
for _, userLogin := range cache[resource.Id.Resource] {
143140
user, resp, err := o.client.Users.Get(ctx, userLogin)
144141
if err != nil {
145-
return nil, "", nil, fmt.Errorf("baton-github: error getting user %s: %w", userLogin, err)
142+
_, reqAnnos, _ := parseResp(resp)
143+
return nil, "", reqAnnos, fmt.Errorf("baton-github: error getting user %s: %w", userLogin, err)
146144
}
147145

148146
principalId, err := resourceSdk.NewResourceID(resourceTypeUser, *user.ID)
149147
if err != nil {
150148
return nil, "", nil, fmt.Errorf("baton-github: error creating resource ID for user %s: %w", userLogin, err)
151149
}
152150

153-
restApiRateLimit, err := extractRateLimitData(resp)
154-
if err != nil {
155-
return nil, "", nil, err
156-
}
157-
annotations.WithRateLimiting(restApiRateLimit)
158-
159151
ret = append(ret, grant.NewGrant(
160152
resource,
161153
"assigned",

0 commit comments

Comments
 (0)