Merge pull request #100 from ConductorOne/jallers/tweak-ratelimit

johnallers · web-flow · commit adc1d5c41a25 · 2025-07-29T11:02:07.000-04:00
Only apply ratelimit check to 403 or 429 again
diff --git a/pkg/connector/helpers.go b/pkg/connector/helpers.go
@@ -230,7 +230,7 @@ func isRatelimited(resp *github.Response) bool {
 	if resp == nil {
 		return false
 	}
-	if resp.Header.Get("X-Ratelimit-Remaining") == "0" {
+	if resp.StatusCode == http.StatusForbidden && resp.Header.Get("X-Ratelimit-Remaining") == "0" {
 		return true
 	}
 	return resp.StatusCode == http.StatusTooManyRequests

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ func isRatelimited(resp *github.Response) bool {`
`230`	`230`	`if resp == nil {`
`231`	`231`	`return false`
`232`	`232`	`}`
`233`		`- if resp.Header.Get("X-Ratelimit-Remaining") == "0" {`
	`233`	`+ if resp.StatusCode == http.StatusForbidden && resp.Header.Get("X-Ratelimit-Remaining") == "0" {`
`234`	`234`	`return true`
`235`	`235`	`}`
`236`	`236`	`return resp.StatusCode == http.StatusTooManyRequests`