[BB-761] baton-github: skip PermissionDenied error #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenleach
reviewed
May 31, 2025
pkg/connector/repository.go
Outdated
| if err != nil { | ||
| if resp.StatusCode == http.StatusForbidden { | ||
| l.Warn("insufficient access to list teams", zap.String("repository", resource.DisplayName)) | ||
| return nil, "", nil, nil |
Contributor
There was a problem hiding this comment.
we shouldn't return empty string for the next page token, if someone has permissions to list repository collaborators but not list repository teams, we are going to skip those grants. instead you can do
err = bag.Next("")
if err != nil {
return nil, "", nil, err
}
pageToken, err := bag.Marshal()
if err != nil {
return nil, "", nil, err
}
return nil, pageToken, nil, nil
laurenleach
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref githubv2 doc
We need to skip the
PermissionDeniederror during sync.There are some places where
Forbiddenerror is ignored. See hereHowever, @btipling says it's a scary feature, since it would churn data if the permission get deleted accidentally when it's shouldn't be.
We could discuss more on that.
Test.
Before changes.
After changes.
