Merge pull request #119 from ConductorOne/ggreer/release-connection

ggreer · web-flow · commit 313e3a8e67ee · 2025-07-30T17:29:59.000-07:00
Release ldap client connection if error is one we don't care about.
diff --git a/pkg/ldap/client.go b/pkg/ldap/client.go
@@ -94,6 +94,7 @@ func (c *Client) getConnection(ctx context.Context, isModify bool, f func(client
 				ldap.LDAPResultUnwillingToPerform,
 				ldap.LDAPResultNoSuchAttribute,
 			) && isModify {
+				cp.Release()
 				return nil
 			}
 			l.Error("baton-ldap: client failed to run function", zap.Error(err))

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,7 @@ func (c *Client) getConnection(ctx context.Context, isModify bool, f func(client`
`94`	`94`	`ldap.LDAPResultUnwillingToPerform,`
`95`	`95`	`ldap.LDAPResultNoSuchAttribute,`
`96`	`96`	`) && isModify {`
	`97`	`+ cp.Release()`
`97`	`98`	`return nil`
`98`	`99`	`}`
`99`	`100`	`l.Error("baton-ldap: client failed to run function", zap.Error(err))`