lint

laurenleach · laurenleach · commit df072cf52b8b · 2025-09-02T18:19:24.000-07:00
diff --git a/pkg/servicenow/client.go b/pkg/servicenow/client.go
@@ -548,8 +548,9 @@ func (c *Client) GetCatalogItemVariablesPlusSets(ctx context.Context, itemSysID
 		}
 	}
 
+	allRaw := itemVarsRaw
 	// Fetch choices for ALL variables (item + set) so selects have options
-	allRaw := append(itemVarsRaw, setVarsRaw...)
+	allRaw = append(allRaw, setVarsRaw...)
 	varIDs := make([]string, 0, len(allRaw))
 	for _, v := range allRaw {
 		varIDs = append(varIDs, v.SysID)
diff --git a/pkg/servicenow/model.go b/pkg/servicenow/model.go
@@ -243,7 +243,7 @@ type LabelEntryName struct {
 	LabelName string `json:"label.name"`
 }
 
-// ServiceNow returns type in different formats
+// ServiceNow returns type in different formats.
 // Example of formats accepted:
 // 8, "8", "", null, {"value":"8","display_value":"Reference"}
 func (t *VariableType) UnmarshalJSON(b []byte) error {

Original file line number	Diff line number	Diff line change
`@@ -548,8 +548,9 @@ func (c *Client) GetCatalogItemVariablesPlusSets(ctx context.Context, itemSysID`
`548`	`548`	`}`
`549`	`549`	`}`
`550`	`550`
	`551`	`+ allRaw := itemVarsRaw`
`551`	`552`	`// Fetch choices for ALL variables (item + set) so selects have options`
`552`		`- allRaw := append(itemVarsRaw, setVarsRaw...)`
	`553`	`+ allRaw = append(allRaw, setVarsRaw...)`
`553`	`554`	`varIDs := make([]string, 0, len(allRaw))`
`554`	`555`	`for _, v := range allRaw {`
`555`	`556`	`varIDs = append(varIDs, v.SysID)`
Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ type LabelEntryName struct {`
`243`	`243`	LabelName string `json:"label.name"`
`244`	`244`	`}`
`245`	`245`
`246`		`-// ServiceNow returns type in different formats`
	`246`	`+// ServiceNow returns type in different formats.`
`247`	`247`	`// Example of formats accepted:`
`248`	`248`	`// 8, "8", "", null, {"value":"8","display_value":"Reference"}`
`249`	`249`	`func (t *VariableType) UnmarshalJSON(b []byte) error {`