Merge pull request #33 from ConductorOne/lauren/inc-376-ret-no-members

return in group grants when member ids len is 0

Author: laurenleach

pkg/connector/group.go

@@ -133,23 +133,15 @@ func (g *groupResourceType) Grants(ctx context.Context, resource *v2.Resource, p
 	}
 
 	memberIDs := mapGroupMembers(groupMembers)
-	targetMembers, _, err := g.client.GetUsers(
-		ctx,
-		servicenow.PaginationVars{
-			Limit: len(memberIDs),
-		},
-		memberIDs,
-	)
-	if err != nil {
-		return nil, "", nil, fmt.Errorf("servicenow-connector: failed to list members under group %s: %w", resource.Id.Resource, err)
+	if len(memberIDs) == 0 {
+		return []*v2.Grant{}, nextPageToken, nil, nil
 	}
 
 	var rv []*v2.Grant
-	for _, member := range targetMembers {
-		memberCopy := member
-		ur, err := userResource(&memberCopy)
+	for _, member := range memberIDs {
+		rID, err := rs.NewResourceID(resourceTypeUser, member)
 		if err != nil {
-			return nil, "", nil, err
+			return nil, "", nil, fmt.Errorf("baton-servicenow: error creating principal id")
 		}
 
 		// grant group membership
@@ -158,7 +150,7 @@ func (g *groupResourceType) Grants(ctx context.Context, resource *v2.Resource, p
 			grant.NewGrant(
 				resource,
 				groupMembership,
-				ur.Id,
+				rID,
 			),
 		)
 	}