[BB-906] baton-sql-server: delete users instead of disabling users when we do account deprovisioning

Bencheng21 · Bencheng21 · commit 41f5bc4165c8 · 2025-07-03T14:37:38.000-07:00
diff --git a/pkg/mssqldb/server.go b/pkg/mssqldb/server.go
@@ -35,13 +35,13 @@ func (c *Client) GetServer(ctx context.Context) (*ServerModel, error) {
 	return &ret, nil
 }
 
-func (c *Client) DisableUserFromServer(ctx context.Context, userName string) error {
+func (c *Client) DeleteUserFromServer(ctx context.Context, userName string) error {
 	if strings.ContainsAny(userName, "[]\"';") {
 		return fmt.Errorf("invalid characters in userName")
 	}
 
 	query := fmt.Sprintf(`
-ALTER LOGIN [%s] DISABLE;`, userName)
+DROP LOGIN [%s];`, userName)
 
 	_, err := c.db.ExecContext(ctx, query)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -35,13 +35,13 @@ func (c Client) GetServer(ctx context.Context) (ServerModel, error) {`
`35`	`35`	`return &ret, nil`
`36`	`36`	`}`
`37`	`37`
`38`		`-func (c *Client) DisableUserFromServer(ctx context.Context, userName string) error {`
	`38`	`+func (c *Client) DeleteUserFromServer(ctx context.Context, userName string) error {`
`39`	`39`	`if strings.ContainsAny(userName, "[]\"';") {`
`40`	`40`	`return fmt.Errorf("invalid characters in userName")`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	query := fmt.Sprintf(`
`44`		-ALTER LOGIN [%s] DISABLE;`, userName)
	`44`	+DROP LOGIN [%s];`, userName)
`45`	`45`
`46`	`46`	`_, err := c.db.ExecContext(ctx, query)`
`47`	`47`	`if err != nil {`