now

Bencheng21 · Bencheng21 · commit de0baf81faf0 · 2025-06-18T17:07:35.000-07:00
diff --git a/pkg/connector/server_user.go b/pkg/connector/server_user.go
@@ -229,7 +229,7 @@ func (d *userPrincipalSyncer) Delete(ctx context.Context, resourceId *v2.Resourc
 	if err != nil {
 		return nil, err
 	}
-	return nil, err
+	return nil, nil
 }
 
 // generateStrongPassword creates a secure random password for SQL Server.
diff --git a/pkg/mssqldb/server.go b/pkg/mssqldb/server.go
@@ -36,6 +36,10 @@ func (c *Client) GetServer(ctx context.Context) (*ServerModel, error) {
 }
 
 func (c *Client) DisableUserFromServer(ctx context.Context, userName string) error {
+	if strings.ContainsAny(userName, "[]\"';") {
+		return fmt.Errorf("invalid characters in userName")
+	}
+
 	query := fmt.Sprintf(`
 ALTER LOGIN [%s] DISABLE;`, userName)
 

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ func (d userPrincipalSyncer) Delete(ctx context.Context, resourceId v2.Resourc`
`229`	`229`	`if err != nil {`
`230`	`230`	`return nil, err`
`231`	`231`	`}`
`232`		`- return nil, err`
	`232`	`+ return nil, nil`
`233`	`233`	`}`
`234`	`234`
`235`	`235`	`// generateStrongPassword creates a secure random password for SQL Server.`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,10 @@ func (c Client) GetServer(ctx context.Context) (ServerModel, error) {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`func (c *Client) DisableUserFromServer(ctx context.Context, userName string) error {`
	`39`	`+ if strings.ContainsAny(userName, "[]\"';") {`
	`40`	`+ return fmt.Errorf("invalid characters in userName")`
	`41`	`+ }`
	`42`	`+`
`39`	`43`	query := fmt.Sprintf(`
`40`	`44`	ALTER LOGIN [%s] DISABLE;`, userName)
`41`	`45`