Merge pull request #32 from ConductorOne/BB906_Delete

[BB-906] baton-sql-server: delete users when we do account deprovisioning.

Author: Bencheng21

pkg/connector/server_user.go

@@ -249,7 +249,7 @@ func (d *userPrincipalSyncer) Delete(ctx context.Context, resourceId *v2.Resourc
 		return nil, err
 	}
 
-	err = d.client.DisableUserFromServer(ctx, user.Name)
+	err = d.client.DeleteUserFromServer(ctx, user.Name)
 	if err != nil {
 		return nil, err
 	}

pkg/mssqldb/server.go

@@ -35,13 +35,13 @@ func (c *Client) GetServer(ctx context.Context) (*ServerModel, error) {
 	return &ret, nil
 }
 
-func (c *Client) DisableUserFromServer(ctx context.Context, userName string) error {
+func (c *Client) DeleteUserFromServer(ctx context.Context, userName string) error {
 	if strings.ContainsAny(userName, "[]\"';") {
 		return fmt.Errorf("invalid characters in userName")
 	}
 
 	query := fmt.Sprintf(`
-ALTER LOGIN [%s] DISABLE;`, userName)
+DROP LOGIN [%s];`, userName)
 
 	_, err := c.db.ExecContext(ctx, query)
 	if err != nil {