better

Author: raulb

source.go

@@ -120,10 +120,6 @@ func (s *Source) Open(ctx context.Context, pos opencdc.Position) error {
 }
 
 func (s *Source) ReadN(ctx context.Context, n int) ([]opencdc.Record, error) {
-	if n <= 0 {
-		return []opencdc.Record{}, nil
-	}
-
 	return s.iterator.NextN(ctx, n)
 }
 

source/logrepl/cdc_test.go

@@ -510,7 +510,7 @@ func TestCDCIterator_NextN(t *testing.T) {
 		}
 
 		// Will keep calling NextN until all records are received
-		var records []opencdc.Record
+		records := make([]opencdc.Record, 0, 2)
 		for len(records) < 2 {
 			recordsTmp, err := i.NextN(ctx, 5)
 			is.NoErr(err)

source/logrepl/combined_test.go

@@ -289,7 +289,7 @@ func TestCombinedIterator_NextN(t *testing.T) {
 		is.NoErr(err)
 
 		// Request 2 records in CDC mode
-		var records []opencdc.Record
+		records := make([]opencdc.Record, 0, 2)
 		var retries int
 		maxRetries := 10
 		for retries < maxRetries {

source/snapshot/iterator.go

@@ -87,7 +87,7 @@ func (i *Iterator) NextN(ctx context.Context, n int) ([]opencdc.Record, error) {
 		return nil, fmt.Errorf("n must be greater than 0, got %d", n)
 	}
 
-	var records []opencdc.Record
+	records := make([]opencdc.Record, 0, n)
 
 	// Get first record (blocking)
 	select {