Update CANopen binding code and related plc4x API calls.

Signed-off-by: Łukasz Dywicki <luke@code-house.org>

Author: splatch

bundles/org.connectorio.addons.binding.amsads/src/main/java/org/connectorio/addons/binding/amsads/internal/handler/channel/AdsChannelHandlerBase.java

@@ -49,7 +49,8 @@ protected AdsChannelHandlerBase(Thing thing, ThingHandlerCallback callback, Chan
     this.thing = thing;
     this.callback = callback;
     this.channel = channel;
-    this.refreshInterval = Optional.ofNullable(channel.getConfiguration())
+    this.refreshInterval = Optional.ofNullable(channel)
+      .map(Channel::getConfiguration)
       .map(cfg -> cfg.get("refreshInterval"))
       .map(val -> val instanceof Long ? (Long) val : Long.parseLong("" + val))
       .orElse(null);

bundles/org.connectorio.addons.binding.canopen.ta/src/main/java/org/connectorio/addons/binding/canopen/ta/internal/handler/protocol/TAOperations.java

@@ -248,8 +248,8 @@ public void accept(PlcSubscriptionEvent event) {
         IndexAddress address = IndexAddress.staticParse(buffer);
         final int subIndex = address.getSubindex();
         short rawValue = buffer.readShort(16);
-        buffer.readUnsignedByte(8); // constant 0x41
-        int unit = buffer.readUnsignedShort(8);
+        buffer.readUnsignedShort(8); // constant 0x41
+        int unit = buffer.readShort(8);
 
         TAValue value = new TAValue(unit, rawValue);
         if (logger.isDebugEnabled()) {

bundles/org.connectorio.addons.binding.canopen.ta/src/main/java/org/connectorio/addons/binding/canopen/ta/tapi/dev/ConfigurationCallback.java

@@ -44,7 +44,7 @@ protected void accept(ReadBuffer buffer) throws ParseException {
     IndexAddress address = IndexAddress.staticParse(buffer);
     final int subIndex = address.getSubindex();
     short rawValue = buffer.readShort(16);
-    buffer.readUnsignedByte(8); // constant 0x41
+    short constant = buffer.readUnsignedShort(8); // constant 0x41
     int unit = buffer.readUnsignedShort(8);
 
     if (logger.isDebugEnabled()) {

bundles/org.connectorio.addons.binding.canopen.ta/src/main/java/org/connectorio/addons/binding/canopen/ta/tapi/io/TAAnalogOutput.java

@@ -75,8 +75,8 @@ void update(byte[] data) {
     try {
       logger.trace("Encoded value for CAN Output {} is {}", this, Hex.encodeHexString(data));
       ReadBuffer buffer = new ReadBufferByteBased(data, ByteOrder.LITTLE_ENDIAN);
-      this.type = buffer.readUnsignedByte(8); // type
-      this.unit = buffer.readUnsignedByte(8); // unit
+      this.type = buffer.readUnsignedShort(8); // type
+      this.unit = buffer.readUnsignedShort(8); // unit
       int numericValue = parseNumber(buffer, data.length);
 
       if (numericValue > Short.MIN_VALUE && numericValue < Short.MAX_VALUE) {