Skip to content

Commit 8d71caa

Browse files
committed
nixos/nvidia-container-toolkit: fix tests
1 parent 986e343 commit 8d71caa

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

nixos/modules/services/hardware/nvidia-container-toolkit/cdi-generate.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ writeScriptBin "nvidia-cdi-generator" ''
3939
--device-name-strategy ${device-name-strategy} \
4040
--ldconfig-path ${lib.getExe' glibc "ldconfig"} \
4141
--library-search-path ${lib.getLib nvidia-driver}/lib \
42-
--nvidia-cdi-hook-path ${lib.getExe' nvidia-container-toolkit.tools "nvidia-cdi-hook"} \
42+
--nvidia-cdi-hook-path ${lib.getOutput "tools" nvidia-container-toolkit}/bin/nvidia-cdi-hook \
4343
${lib.escapeShellArgs extraArgs}
4444
}
4545

nixos/tests/nvidia-container-toolkit.nix

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ let
8585
'';
8686
meta.mainProgram = "nvidia-ctk";
8787
};
88+
suppressNvidiaDriverAssertion = true;
8889
};
8990
in
9091
{
@@ -100,7 +101,10 @@ in
100101
{
101102
environment.systemPackages = with pkgs; [ jq ];
102103
virtualisation.diskSize = lib.mkDefault 10240;
103-
virtualisation.containers.enable = lib.mkDefault true;
104+
virtualisation.containers = {
105+
containersConf.settings.engine.cdi_spec_dirs = [ "/var/run/cdi" ];
106+
enable = lib.mkDefault true;
107+
};
104108
hardware = {
105109
inherit nvidia-container-toolkit;
106110
nvidia = {
@@ -113,8 +117,8 @@ in
113117
nodes = {
114118
no-gpus = {
115119
virtualisation.containers.enable = false;
116-
hardware.graphics.enable = false;
117120
};
121+
118122
one-gpu =
119123
{ pkgs, ... }:
120124
{
@@ -142,7 +146,7 @@ in
142146
one_gpu.wait_for_unit("nvidia-container-toolkit-cdi-generator.service")
143147
one_gpu.succeed("cat /var/run/cdi/nvidia-container-toolkit.json | jq")
144148
one_gpu.succeed("podman load < ${testContainerImage}")
145-
print(one_gpu.succeed("podman run --pull=never --device=nvidia.com/gpu=all -v /run/opengl-driver:/run/opengl-driver:ro cdi-test:latest"))
149+
one_gpu.succeed("podman run --pull=never --device=nvidia.com/gpu=all -v /run/opengl-driver:/run/opengl-driver:ro cdi-test:latest")
146150
147151
# Issue: https://github.com/NixOS/nixpkgs/issues/319201
148152
with subtest("The generated CDI spec skips specified non-existant paths in the host"):

0 commit comments

Comments
 (0)