Skip to content

Commit d69d9cc

Browse files
committed
Revert "no real tests, but testing is there."
This reverts commit 54f4ee2.
1 parent 5bac116 commit d69d9cc

File tree

12 files changed

+23
-138
lines changed

12 files changed

+23
-138
lines changed

.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,3 @@ node_modules
22
npm-debug.log
33
tmp
44
*.swp
5-
coverage
6-
dist

Gruntfile.js

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,30 @@ module.exports = function(grunt) {
1717
node_version: {
1818
project: {
1919
options: {
20-
debug: true,
21-
override: ">=6.2.0"
20+
alwaysInstall: false,
21+
errorLevel: "fatal",
22+
globals: [],
23+
nvm: true,
24+
override: "",
25+
debug: false
26+
}
27+
},
28+
latest: {
29+
options: {
30+
alwaysInstall: false,
31+
errorLevel: "fatal",
32+
globals: ["jshint"],
33+
nvm: true,
34+
override: "6.2.0",
35+
debug: false
2236
}
2337
}
2438
}
2539
});
2640

2741
// Actually load this plugin"s task(s).
2842
grunt.loadTasks("tasks");
29-
// Load the tasks for developing this plugin.
30-
grunt.loadTasks("grunt");
3143

32-
grunt.registerTask("test", ["browserify", "qunit", "coveralls"]);
33-
grunt.registerTask("default", []);
44+
// By default, lint and run the task.
45+
grunt.registerTask("default", ["node_version"]);
3446
};

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# grunt-node-version-windows
22
[![Build Status](https://travis-ci.org/Conrad2134/grunt-node-version-windows.svg?branch=master)](https://travis-ci.org/Conrad2134/grunt-node-version-windows)
33
[![npm version](https://badge.fury.io/js/grunt-node-version-windows.svg)](https://badge.fury.io/js/grunt-node-version-windows)
4-
[![Coverage Status](https://coveralls.io/repos/github/Conrad2134/grunt-node-version-windows/badge.svg?branch=master)](https://coveralls.io/github/Conrad2134/grunt-node-version-windows?branch=master)
54

65
> A grunt task to ensure you are using the node version required by your project's package.json
76

TODO.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,3 @@
88
### Future
99
- Mocking of commands for testing (is it possible?)
1010
- Are there modules we can use to better interface with npm / nvm-windows?
11-
- eslint over jshint

grunt/browserify.js

Lines changed: 0 additions & 48 deletions
This file was deleted.

grunt/coveralls.js

Lines changed: 0 additions & 12 deletions
This file was deleted.

grunt/qunit.js

Lines changed: 0 additions & 24 deletions
This file was deleted.

package.json

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,11 @@
1818
},
1919
"scripts": {
2020
"lint": "jshint tasks --config .jshintrc || true",
21-
"test": "npm run lint && grunt test --force"
21+
"test": "npm run lint"
2222
},
2323
"devDependencies": {
24-
"babel-preset-es2015": "^6.9.0",
25-
"babelify": "^7.3.0",
2624
"grunt": "^1.0.1",
27-
"grunt-browserify": "^5.0.0",
28-
"grunt-coveralls": "^1.0.1",
29-
"grunt-qunit-istanbul": "^0.6.0",
30-
"jquery": "^2.2.3",
31-
"jshint": "^2.9.2",
32-
"qunitjs": "^2.0.0-rc1"
25+
"jshint": "^2.9.2"
3326
},
3427
"peerDependencies": {
3528
"grunt": ">=0.4.0"
@@ -44,7 +37,6 @@
4437
],
4538
"dependencies": {
4639
"chalk": "^1.1.3",
47-
"process": "^0.11.3",
4840
"prompt": "^1.0.0",
4941
"semver": "^5.1.0",
5042
"stripcolorcodes": "^0.1.0"

src/npm.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010

1111
"use strict";
1212

13-
var childProcess = require("child_process"),
14-
process = require("process");
15-
13+
var childProcess = require("child_process");
14+
1615
/**
1716
* Provides an interface to npm.
1817
*/

src/nvm.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@
1212

1313
var childProcess = require("child_process"),
1414
semver = require("semver"),
15-
stripColorCodes = require("stripcolorcodes"),
16-
process = require("process");
15+
stripColorCodes = require("stripcolorcodes");
1716

1817
/**
1918
* Provides an interface to nvm-windows.

0 commit comments

Comments
 (0)