fix eth_getBlockTransactionCountByHash to work with forks

Author: Andres Adjimann

src/chains/ethereum/ethereum/src/api.ts

@@ -1266,14 +1266,12 @@ export default class EthereumApi implements Api {
   @assertArgLength(1)
   async eth_getBlockTransactionCountByHash(hash: DATA) {
     const { blocks } = this.#blockchain;
-    const blockNum = await blocks.getNumberFromHash(hash);
-    if (!blockNum) return null;
-
-    const rawBlock = await blocks.getRawByBlockNumber(Quantity.from(blockNum));
-    if (!rawBlock) return null;
-
-    const [, rawTransactions] = decode<GanacheRawBlock>(rawBlock);
-    return Quantity.from(rawTransactions.length);
+    const block = await blocks
+      .getByHash(hash)
+      .catch<Block>(_ => null);
+    if (!block) return null;
+    const transactions = block.getTransactions();
+    return Quantity.from(transactions.length);
   }
 
   /**

src/chains/ethereum/ethereum/src/data-managers/block-manager.ts

@@ -173,7 +173,7 @@ export default class BlockManager extends Manager<Block> {
     return Quantity.from(tagOrBlockNumber);
   }
 
-  async getNumberFromHash(hash: string | Buffer | Tag) {
+  private async getNumberFromHash(hash: string | Buffer | Tag) {
     return this.#blockIndexes.get(Data.toBuffer(hash)).catch(e => {
       if (e.status === NOTFOUND) return null;
       throw e;