correct check for window variable

eggplantzzz · eggplantzzz · commit 145cbb2d05ca · 2023-01-11T16:23:36.000-05:00
diff --git a/packages/fetch-and-compile/.eslintrc.json b/packages/fetch-and-compile/.eslintrc.json
@@ -1,3 +1,6 @@
 {
-    "extends": ["../../.eslintrc.package.json"]
+    "extends": ["../../.eslintrc.package.json"],
+    "env": {
+      "browser": "readonly"
+    }
 }
diff --git a/packages/fetch-and-compile/lib/fetch.ts b/packages/fetch-and-compile/lib/fetch.ts
@@ -136,7 +136,7 @@ async function tryFetchAndCompileAddress(
     });
 
     // @ts-ignore
-    if (window) {
+    if (typeof window === "undefined") {
       externalConfig.compilers.cache = "noCache";
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,6 @@`
`1`	`1`	`{`
`2`		`- "extends": ["../../.eslintrc.package.json"]`
	`2`	`+ "extends": ["../../.eslintrc.package.json"],`
	`3`	`+ "env": {`
	`4`	`+ "browser": "readonly"`
	`5`	`+ }`
`3`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ async function tryFetchAndCompileAddress(`
`136`	`136`	`});`
`137`	`137`
`138`	`138`	`// @ts-ignore`
`139`		`- if (window) {`
	`139`	`+ if (typeof window === "undefined") {`
`140`	`140`	`externalConfig.compilers.cache = "noCache";`
`141`	`141`	`}`
`142`	`142`