refact processHelpInput to inline check on cli.js

Author: lsqproduction

packages/core/cli.js

@@ -46,15 +46,32 @@ const {
   getCommand,
   prepareOptions,
   runCommand,
-  processHelpInput
+  displayGeneralHelp
 } = require("./lib/command-utils");
 
-//if `help` or `--help` is in the command, validate and transform the input
+//User only enter truffle with no commands, let's show them what's available.
+if (inputStrings.length === 0) {
+  displayGeneralHelp();
+  process.exit();
+}
+
+//if `help` or `--help` is in the command, validate and transform the input argument for help
 if (
   inputStrings.some(inputString => ["help", "--help"].includes(inputString))
 ) {
-  //handle general help case and displayCommand Help cases and return the inputStrings to be process further
-  processHelpInput(inputStrings);
+  //when user wants general help
+  if (inputStrings.length === 1) {
+    displayGeneralHelp();
+    process.exit();
+  }
+
+  //check where is --help used, mutate argument into a proper help command
+  const helpIndex = inputStrings.indexOf("--help");
+
+  if (helpIndex !== -1) {
+    inputStrings.splice(helpIndex, 1);
+    inputStrings.unshift("help");
+  }
 }
 
 const command = getCommand({

packages/core/lib/command-utils.js

@@ -203,26 +203,6 @@ const runCommand = async function (command, options) {
   return await command.run(options);
 };
 
-const processHelpInput = inputStrings => {
-  //  handle general help case and displayCommand Help cases
-
-  //when user wants general help
-  if (inputStrings.length === 0 || inputStrings.length === 1) {
-    displayGeneralHelp();
-    process.exit();
-  }
-
-  //check where is --help used
-  const helpIndex = inputStrings.indexOf("--help");
-
-  if (helpIndex !== -1) {
-    inputStrings.splice(helpIndex, 1);
-    inputStrings.unshift("help");
-  }
-
-  return inputStrings;
-};
-
 const displayGeneralHelp = () => {
   const yargs = require("yargs/yargs")();
   commands.forEach(command => {
@@ -327,7 +307,6 @@ const deriveConfigEnvironment = function (detectedConfig, network, url) {
 };
 
 module.exports = {
-  processHelpInput,
   displayGeneralHelp,
   getCommand,
   prepareOptions,