Skip to content

Commit 0e6e75c

Browse files
committed
chore: more uses of BitReverse
1 parent 8f6bfe8 commit 0e6e75c

File tree

16 files changed

+40
-24
lines changed

16 files changed

+40
-24
lines changed

backend/plonk/bls12-377/prove.go

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

backend/plonk/bls12-381/prove.go

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

backend/plonk/bls24-315/prove.go

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

backend/plonk/bls24-317/prove.go

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

backend/plonk/bn254/prove.go

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

backend/plonk/bw6-633/prove.go

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

backend/plonk/bw6-761/prove.go

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/generator/backend/template/gkr/gate_testing.go.tmpl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import (
66
"github.com/consensys/gnark/std/gkrapi/gkr"
77
"{{.FieldPackagePath}}"
88
{{- if .CanUseFFT }}
9+
gcutils "github.com/consensys/gnark-crypto/utils"
910
"{{.FieldPackagePath}}/fft"
1011
"sync"{{- else}}
1112
"errors"{{- end }}
@@ -89,7 +90,7 @@ func (f gateFunctionFr) fitPoly(nbIn int, degreeBound uint64) polynomial.Polynom
8990

9091
// obtain p's coefficients
9192
domain.FFTInverse(p, fft.DIF)
92-
fft.BitReverse(p)
93+
gcutils.BitReverse(p)
9394
{{- else }}
9495
x := make({{.FieldPackageName}}.Vector, degreeBound)
9596
x.MustSetRandom()

internal/generator/backend/template/zkpschemes/plonk/plonk.prove.go.tmpl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import (
1212
"golang.org/x/sync/errgroup"
1313

1414
"github.com/consensys/gnark-crypto/ecc"
15+
gcutils "github.com/consensys/gnark-crypto/utils"
1516
{{ template "import_curve" . }}
1617
{{ template "import_fr" . }}
1718
{{ template "import_fft" . }}
@@ -895,7 +896,7 @@ func (s *instance) computeNumerator() (*iop.Polynomial, error) {
895896
scalingVector := cosetTable
896897
scalingVectorRev := make([]fr.Element, len(cosetTable))
897898
copy(scalingVectorRev, cosetTable)
898-
fft.BitReverse(scalingVectorRev)
899+
gcutils.BitReverse(scalingVectorRev)
899900

900901
// pre-computed to compute the bit reverse index
901902
// of the result polynomial
@@ -936,7 +937,7 @@ func (s *instance) computeNumerator() (*iop.Polynomial, error) {
936937

937938
// reuse memory
938939
copy(scalingVectorRev, scalingVector)
939-
fft.BitReverse(scalingVectorRev)
940+
gcutils.BitReverse(scalingVectorRev)
940941
}
941942

942943
// we do **a lot** of FFT here, but on the small domain.

internal/gkr/bls12-377/gate_testing.go

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)