Skip to content
This repository was archived by the owner on Jul 1, 2025. It is now read-only.

Commit cb25c5b

Browse files
siladugaryschulte
authored andcommitted
Remove EIP-7742 (#8083)
This EIP was removed and equivalent functionality replaced by EIP-7840. --- Revert "Rename targetBlobCount to targetBlobsPerBlock (#7981)" This reverts commit 16713067490dc99ad36b21fa3d85d9dc639030ef. Revert "EIP-7742: Add target_blob_count to block header (#7808)" This reverts commit f855d5b72fb5e44977d995f48872cdb976333711. Signed-off-by: Simon Dudley <[email protected]>
1 parent 59fb31a commit cb25c5b

File tree

30 files changed

+15
-141
lines changed

30 files changed

+15
-141
lines changed

acceptance-tests/dsl/src/main/java/org/hyperledger/besu/tests/acceptance/dsl/BlockUtils.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ public static BlockHeader createBlockHeader(
5858
null,
5959
null,
6060
null,
61-
null,
6261
blockHeaderFunctions);
6362
}
6463
}

acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/jsonrpc/ExecutionEnginePragueAcceptanceTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,8 @@
2020

2121
import org.junit.jupiter.api.AfterAll;
2222
import org.junit.jupiter.api.BeforeAll;
23-
import org.junit.jupiter.api.Disabled;
2423
import org.junit.jupiter.params.provider.Arguments;
2524

26-
// TODO SLD
27-
@Disabled("TODO SLD - Enable when Prague spec is finalized")
2825
public class ExecutionEnginePragueAcceptanceTest extends AbstractJsonRpcTest {
2926
private static final String GENESIS_FILE = "/jsonrpc/engine/prague/genesis.json";
3027
private static final String TEST_CASE_PATH = "/jsonrpc/engine/prague/test-cases/";

besu/src/test/java/org/hyperledger/besu/controller/AbstractBftBesuControllerBuilderTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,6 @@ public void miningParametersBlockPeriodSecondsIsUpdatedOnTransition() {
195195
null,
196196
null,
197197
null,
198-
null,
199198
getBlockHeaderFunctions());
200199
final Block block1 = new Block(header1, BlockBody.empty());
201200

besu/src/test/java/org/hyperledger/besu/controller/CliqueBesuControllerBuilderTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,6 @@ public void miningParametersBlockPeriodSecondsIsUpdatedOnTransition() {
224224
null,
225225
null,
226226
null,
227-
null,
228227
new CliqueBlockHeaderFunctions());
229228
final Block block1 = new Block(header1, BlockBody.empty());
230229

besu/src/test/java/org/hyperledger/besu/services/BesuEventsImplTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ private void setSyncTarget() {
219219
mock(EthPeer.class),
220220
new org.hyperledger.besu.ethereum.core.BlockHeader(
221221
null, null, null, null, null, null, null, null, 1, 1, 1, 1, null, null, null, 1, null,
222-
null, null, null, null, null, null));
222+
null, null, null, null, null));
223223
}
224224

225225
private void clearSyncTarget() {

config/src/main/java/org/hyperledger/besu/config/GenesisConfig.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -265,17 +265,6 @@ public String getParentBeaconBlockRoot() {
265265
"0x0000000000000000000000000000000000000000000000000000000000000000");
266266
}
267267

268-
/**
269-
* Gets target blobs per block.
270-
*
271-
* @return the target blobs per block
272-
*/
273-
public Optional<String> getTargetBlobsPerBlock() {
274-
// TODO SLD EIP-7742 not sure if we should use a default value here or enforce any
275-
// "pragueAtGenesis" genesis file (used in devnets) to have this value
276-
return JsonUtil.getValueAsString(genesisRoot, "targetblobsperblock");
277-
}
278-
279268
/**
280269
* Gets coinbase.
281270
*

ethereum/api/src/integration-test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcResponseKey.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,5 @@ public enum JsonRpcResponseKey {
3838
TRANSACTION_ROOT,
3939
BASEFEE,
4040
WITHDRAWALS_ROOT,
41-
REQUESTS_HASH,
42-
TARGET_BLOBS_PER_BLOCK
41+
REQUESTS_HASH
4342
}

ethereum/api/src/integration-test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcResponseUtils.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@
6363
import com.fasterxml.jackson.databind.JsonNode;
6464
import org.apache.tuweni.bytes.Bytes;
6565
import org.apache.tuweni.units.bigints.UInt256;
66-
import org.apache.tuweni.units.bigints.UInt64;
6766

6867
public class JsonRpcResponseUtils {
6968

@@ -107,10 +106,6 @@ public JsonRpcResponse response(
107106
values.containsKey(WITHDRAWALS_ROOT) ? hash(values.get(WITHDRAWALS_ROOT)) : null;
108107
final Hash requestsHash =
109108
values.containsKey(REQUESTS_HASH) ? hash(values.get(REQUESTS_HASH)) : null;
110-
final UInt64 targetBlobsPerBlock =
111-
values.containsKey(JsonRpcResponseKey.TARGET_BLOBS_PER_BLOCK)
112-
? UInt64.fromHexString(values.get(JsonRpcResponseKey.TARGET_BLOBS_PER_BLOCK))
113-
: null;
114109
final List<JsonNode> ommers = new ArrayList<>();
115110

116111
final BlockHeader header =
@@ -136,7 +131,6 @@ public JsonRpcResponse response(
136131
null, // ToDo 4844: set with the value of excess_blob_gas field
137132
null, // TODO 4788: set with the value of the parent beacon block root field
138133
requestsHash,
139-
targetBlobsPerBlock,
140134
blockHeaderFunctions);
141135

142136
return new JsonRpcSuccessResponse(

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/AbstractEngineNewPayload.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,6 @@ public JsonRpcResponse syncResponse(final JsonRpcRequestContext requestContext)
266266
: BlobGas.fromHexString(blockParam.getExcessBlobGas()),
267267
maybeParentBeaconBlockRoot.orElse(null),
268268
maybeRequests.map(BodyValidation::requestsHash).orElse(null),
269-
null, // TODO SLD EIP-7742 wiring in future PR
270269
headerFunctions);
271270

272271
// ensure the block hash matches the blockParam hash

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/BlockResult.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ public class BlockResult implements JsonRpcResult {
8888
private final String blobGasUsed;
8989
private final String excessBlobGas;
9090
private final String parentBeaconBlockRoot;
91-
private final String targetBlobsPerBlock;
9291
private final List<CallProcessingResult> callProcessingResults;
9392

9493
public BlockResult(
@@ -153,7 +152,6 @@ public BlockResult(
153152
this.excessBlobGas = header.getExcessBlobGas().map(Quantity::create).orElse(null);
154153
this.parentBeaconBlockRoot =
155154
header.getParentBeaconBlockRoot().map(Bytes32::toHexString).orElse(null);
156-
this.targetBlobsPerBlock = header.getTargetBlobsPerBlock().map(Quantity::create).orElse(null);
157155
}
158156

159157
@JsonGetter(value = "number")
@@ -292,11 +290,6 @@ public String getParentBeaconBlockRoot() {
292290
return parentBeaconBlockRoot;
293291
}
294292

295-
@JsonGetter(value = "targetBlobsPerBlock")
296-
public String getTargetBlobsPerBlock() {
297-
return targetBlobsPerBlock;
298-
}
299-
300293
@JsonGetter(value = "calls")
301294
public List<CallProcessingResult> getTransactionProcessingResults() {
302295
return callProcessingResults;

0 commit comments

Comments
 (0)