Open
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| dependency 'org.xipki.iaik:sunpkcs11-wrapper:1.4.10' | ||
|
|
||
| dependencySet(group: 'tech.pegasys.teku.internal', version: '25.11.0') { | ||
| dependencySet(group: 'tech.pegasys.teku.internal', version: '26.2.0') { |
There was a problem hiding this comment.
KZGCommitment not updated alongside KZGProof API migration
High Severity
The Teku version bump to 26.2.0 required updating KZGProof to use getBytesCompressed()/fromBytesCompressed() instead of toSSZBytes()/fromSSZBytes(), but the sibling class KZGCommitment (same tech.pegasys.teku.kzg package) still calls kzgCommitment.toSSZBytes() on line 38 and KZGCommitment.fromSSZBytes(bytes) on line 85. If the same API rename was applied to KZGCommitment in Teku 26.2.0, this is a build-breaking oversight.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing
Note
Medium Risk
Medium risk because it bumps core Teku dependencies and updates Eth2 schema conversions (KZG proof encoding and Electra withdrawal index typing), which can affect signing/request compatibility at runtime.
Overview
Updates Teku internal libraries to
26.2.0and records the upgrade in the changelog.Adjusts Eth2 schema adapters to match Teku API/type changes:
KZGProofnow uses compressed-byte encoding (getBytesCompressed/fromBytesCompressedviaBytes48), andPendingPartialWithdrawalconvertsvalidator_indexfrom Teku’s unsigned type to anint.Written by Cursor Bugbot for commit 917a9ce. This will update automatically on new commits. Configure here.