Skip to content

Commit 60bcdab

Browse files
Fix commented ARGs
1 parent 3317c11 commit 60bcdab

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

.github/workflows/publish.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,10 @@ jobs:
3030

3131
- name: Run tests
3232
run: |
33-
if [ -f docker-compose.test.yml ]; then
34-
docker-compose --file docker-compose.test.yml build
35-
docker-compose --file docker-compose.test.yml run sut
36-
else
37-
docker build . \
38-
--build-arg FETCHER_IMAGE_VERSION=${FETCHER_IMAGE_VERSION} \
39-
--build-arg BASE_IMAGE_VERSION=${BASE_IMAGE_VERSION} \
40-
--file Dockerfile --tag $IMAGE_NAME
41-
fi
33+
docker build . \
34+
--build-arg FETCHER_IMAGE_VERSION=${FETCHER_IMAGE_VERSION} \
35+
--build-arg BASE_IMAGE_VERSION=${BASE_IMAGE_VERSION} \
36+
--file Dockerfile --tag $IMAGE_NAME
4237
# Push image to GitHub Packages.
4338
# See also https://docs.docker.com/docker-hub/builds/
4439
push:

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
# ARG FETCHER_IMAGE_VERSION=3.15.0
2-
# ARG BASE_IMAGE_VERSION=commit-f2d623ca9d270c2ce8560d2ca0f9ce71b105aff2
1+
ARG FETCHER_IMAGE_VERSION
2+
ARG BASE_IMAGE_VERSION
33

44
# Based on https://github.com/gitpod-io/workspace-images/blob/master/base/Dockerfile and https://github.com/gitpod-io/workspace-images/blob/master/full/Dockerfile
55

0 commit comments

Comments
 (0)