Merge pull request #5 from antoinebou12/windows-cuda

Remove -fpic from Windows CUDA issue with the build for ipc-toolkit with vcpkg on Windows

Author: zfergus

.github/workflows/continuous.yml

@@ -164,4 +164,4 @@ jobs:
 
       # GitHub Actions does not support CUDA, so we cannot run the tests.
       # - name: Tests
-      #   run: cd build; ctest --verbose -j2
+      #   run: cd build; ctest --verbose -j2

CMakeLists.txt

@@ -169,7 +169,7 @@ if(SCALABLE_CCD_WITH_CUDA)
   # library to be built with -dc as the member functions could be called by
   # other libraries and executables.
   set_target_properties(scalable_ccd PROPERTIES CUDA_SEPARABLE_COMPILATION ON)
-
+  
   if(DEFINED SCALABLE_CCD_CUDA_ARCHITECTURES)
     message(STATUS "CUDA_ARCHITECTURES was specified, skipping auto-detection")
     set(CMAKE_CUDA_ARCHITECTURES ${SCALABLE_CCD_CUDA_ARCHITECTURES})
@@ -195,15 +195,13 @@ if(SCALABLE_CCD_WITH_CUDA)
       BUILD_RPATH ${CMAKE_CUDA_IMPLICIT_LINK_DIRECTORIES})
   endif()
 
-  target_compile_options(scalable_ccd PRIVATE $<$<COMPILE_LANGUAGE:CUDA>:
-    --generate-line-info
-    --use_fast_math
-    --relocatable-device-code=true
-
-    # --ptxas-options=-v
-    # --maxrregcount=7
-    -fPIC # https://stackoverflow.com/questions/5311515/gcc-fpic-option
-    >)
+  target_compile_options(scalable_ccd PRIVATE 
+    $<$<COMPILE_LANGUAGE:CUDA>:
+      --generate-line-info
+      --use_fast_math
+      --relocatable-device-code=true
+    >
+  )
 
   find_package(CUDAToolkit)
   target_link_libraries(scalable_ccd PUBLIC CUDA::cudart)
@@ -218,4 +216,4 @@ if(SCALABLE_CCD_TOPLEVEL_PROJECT AND SCALABLE_CCD_BUILD_TESTS)
   include(CTest)
   enable_testing()
   add_subdirectory(tests)
-endif()
+endif()