Skip to content

Commit 029ca74

Browse files
committed
Fix spelling and formatting in CCD function comments
1 parent 4b3603b commit 029ca74

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

src/tight_inclusion/ccd.hpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ namespace ticcd {
1414
BREADTH_FIRST_SEARCH,
1515
};
1616

17-
/// @brief This function can give you the answer of continous collision detection with minimum
18-
/// seperation, and the earlist collision time if collision happens.
17+
/// @brief This function can give you the answer of continuous collision detection with minimum
18+
/// separation, and the earliest collision time if collision happens.
1919
///
2020
/// @param[in] ea0_t0 The start position of the first vertex of the first edge.
2121
/// @param[in] ea1_t0 The start position of the second vertex of the first edge.
@@ -27,8 +27,8 @@ namespace ticcd {
2727
/// @param[in] eb1_t1 The end position of the second vertex of the second edge.
2828
/// @param[in] err The filters calculated using the bounding box of the simulation scene.
2929
/// If you are checking a single query without a scene, please set it as {-1,-1,-1}.
30-
/// @param[in] ms The minimum seperation. should set: ms < max(abs(x),1), ms < max(abs(y),1), ms < max(abs(z),1) of the QUERY (NOT THE SCENE!).
31-
/// @param[out] toi The earlist time of collision if collision happens. If there is no collision, toi will be infinate.
30+
/// @param[in] ms The minimum separation. should set: ms < max(abs(x),1), ms < max(abs(y),1), ms < max(abs(z),1) of the QUERY (NOT THE SCENE!).
31+
/// @param[out] toi The earliest time of collision if collision happens. If there is no collision, toi will be infinite.
3232
/// @param[in] tolerance A user - input solving precision. We suggest to use 1e-6.
3333
/// @param[in] t_max The upper bound of the time interval [0,t_max] to be checked. 0<=t_max<=1
3434
/// @param[in] max_itr A user-defined value to terminate the algorithm earlier, and return a result under current
@@ -57,8 +57,8 @@ namespace ticcd {
5757
const CCDRootFindingMethod ccd_method =
5858
CCDRootFindingMethod::BREADTH_FIRST_SEARCH);
5959

60-
/// This function can give you the answer of continous collision detection with minimum
61-
/// seperation, and the earlist collision time if collision happens.
60+
/// This function can give you the answer of continuous collision detection with minimum
61+
/// separation, and the earliest collision time if collision happens.
6262
///
6363
/// @param[in] v_t0 The start position of the vertex.
6464
/// @param[in] f0_t0 The start position of the first vertex of the face.
@@ -70,8 +70,8 @@ namespace ticcd {
7070
/// @param[in] f2_t1 The end position of the third vertex of the face.
7171
/// @param[in] err The filters calculated using the bounding box of the simulation scene.
7272
/// If you are checking a single query without a scene, please set it as {-1,-1,-1}.
73-
/// @param[in] ms The minimum seperation. should set: ms < max(abs(x),1), ms < max(abs(y),1), ms < max(abs(z),1) of the QUERY (NOT THE SCENE!).
74-
/// @param[out] toi The earlist time of collision if collision happens. If there is no collision, toi will be infinate.
73+
/// @param[in] ms The minimum separation. should set: ms < max(abs(x),1), ms < max(abs(y),1), ms < max(abs(z),1) of the QUERY (NOT THE SCENE!).
74+
/// @param[out] toi The earliest time of collision if collision happens. If there is no collision, toi will be infinite.
7575
/// @param[in] tolerance A user - input solving precision. We suggest to use 1e-6.
7676
/// @param[in] t_max The upper bound of the time interval [0,t_max] to be checked. 0<=t_max<=1
7777
/// @param[in] max_itr A user-defined value to terminate the algorithm earlier, and return a result under current
@@ -124,7 +124,7 @@ namespace ticcd {
124124

125125
long return_queue_size();
126126

127-
// these function are designed to test the performance of floating point vertion but with double inputs
127+
// these function are designed to test the performance of floating point version but with double inputs
128128
#ifdef TIGHT_INCLUSION_FLOAT_WITH_DOUBLE_INPUT
129129
bool edgeEdgeCCD(
130130
const Eigen::Vector3d &ea0_t0,

src/tight_inclusion/interval_root_finder.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -601,8 +601,7 @@ namespace ticcd {
601601
eefilter = 3.337861e-06;
602602
vffilter = 3.576279e-06;
603603
#endif
604-
} else // using minimum separation
605-
{
604+
} else { // using minimum separation
606605
#ifdef TIGHT_INCLUSION_WITH_DOUBLE_PRECISION
607606
eefilter = 7.105427357601002e-15;
608607
vffilter = 7.549516567451064e-15;
@@ -613,7 +612,7 @@ namespace ticcd {
613612
}
614613

615614
Vector3 max = vertices[0].cwiseAbs();
616-
for (int i = 0; i < vertices.size(); i++) {
615+
for (int i = 1; i < vertices.size(); i++) {
617616
max = max.cwiseMax(vertices[i].cwiseAbs());
618617
}
619618
Vector3 delta = max.cwiseMin(1);

0 commit comments

Comments
 (0)