Skip to content

Commit 05a852c

Browse files
committed
add a TODO for time accuracy
1 parent b0b3647 commit 05a852c

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

tight_inclusion/interval_root_finder.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1930,6 +1930,7 @@ namespace inclusion_ccd
19301930
this_level_less_tol = false;
19311931
// this level has at least one box whose size > tolerance, thus we
19321932
// cannot directly return if find one box whose size < tolerance or box-in
1933+
//TODO think about it. maybe we can return even if this value is false, so we can terminate earlier.
19331934
}
19341935

19351936
// Condition 3, in this level, we find a box that zero-in and size < tolerance.
@@ -1942,7 +1943,7 @@ namespace inclusion_ccd
19421943
rnbr++;
19431944
// continue;
19441945
toi = Numccd2double(TOI) * impact_ratio;
1945-
//std::cout << "return 1" << std::endl;
1946+
//std::cout << "return 1" << std::endl;
19461947
return true;
19471948
// we don't need to compare with TOI_SKIP because we already continue
19481949
// when t>=TOI_SKIP
@@ -2384,7 +2385,7 @@ namespace inclusion_ccd
23842385
vffilter = 6.661338147750939e-15;
23852386
#else
23862387
eefilter = 3.337861e-06;
2387-
vffilter = 3.576279e-06;
2388+
vffilter = 3.576279e-06;
23882389
#endif
23892390
}
23902391
else // using minimum separation
@@ -2393,7 +2394,7 @@ namespace inclusion_ccd
23932394
eefilter = 7.105427357601002e-15;
23942395
vffilter = 7.549516567451064e-15;
23952396
#else
2396-
eefilter = 3.814698e-06;
2397+
eefilter = 3.814698e-06;
23972398
vffilter = 4.053116e-06;
23982399
#endif
23992400
}

0 commit comments

Comments
 (0)