Skip to content

Commit 1c66674

Browse files
committed
Replace emplace_back with std::vector literal
1 parent 0379870 commit 1c66674

File tree

2 files changed

+11
-40
lines changed

2 files changed

+11
-40
lines changed

tight_inclusion/ccd.cpp

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -164,16 +164,8 @@ namespace ticcd {
164164
Array3 err;
165165
// if error[0]<0, means we need to calculate error here
166166
if (err_in[0] < 0) {
167-
std::vector<Vector3> vlist;
168-
vlist.emplace_back(a0s);
169-
vlist.emplace_back(a1s);
170-
vlist.emplace_back(b0s);
171-
vlist.emplace_back(b1s);
172-
173-
vlist.emplace_back(a0e);
174-
vlist.emplace_back(a1e);
175-
vlist.emplace_back(b0e);
176-
vlist.emplace_back(b1e);
167+
std::vector<Vector3> vlist = {
168+
{a0s, a1s, b0s, b1s, a0e, a1e, b0e, b1e}};
177169
bool use_ms = ms > 0;
178170
err = get_numerical_error(vlist, false, use_ms);
179171
} else {
@@ -273,16 +265,10 @@ namespace ticcd {
273265
Array3 err;
274266
// if error[0]<0, means we need to calculate error here
275267
if (err_in[0] < 0) {
276-
std::vector<Vector3> vlist;
277-
vlist.emplace_back(vertex_start);
278-
vlist.emplace_back(face_vertex0_start);
279-
vlist.emplace_back(face_vertex1_start);
280-
vlist.emplace_back(face_vertex2_start);
281-
282-
vlist.emplace_back(vertex_end);
283-
vlist.emplace_back(face_vertex0_end);
284-
vlist.emplace_back(face_vertex1_end);
285-
vlist.emplace_back(face_vertex2_end);
268+
std::vector<Vector3> vlist = {
269+
{vertex_start, face_vertex0_start, face_vertex1_start,
270+
face_vertex2_start, vertex_end, face_vertex0_end,
271+
face_vertex1_end, face_vertex2_end}};
286272
bool use_ms = ms > 0;
287273
err = get_numerical_error(vlist, true, use_ms);
288274
} else {

tight_inclusion/rational/ccd.cpp

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -28,16 +28,7 @@ namespace ticcd::rational {
2828

2929
//////////////////////////////////////////////////////////
3030
// TODO this should be the error of the whole mesh
31-
std::vector<Vector3> vlist;
32-
vlist.emplace_back(a0s);
33-
vlist.emplace_back(a1s);
34-
vlist.emplace_back(b0s);
35-
vlist.emplace_back(b1s);
36-
37-
vlist.emplace_back(a0e);
38-
vlist.emplace_back(a1e);
39-
vlist.emplace_back(b0e);
40-
vlist.emplace_back(b1e);
31+
std::vector<Vector3> vlist = {{a0s, a1s, b0s, b1s, a0e, a1e, b0e, b1e}};
4132

4233
bool use_ms = ms > 0;
4334
Array3 auto_err = get_numerical_error(vlist, false, use_ms);
@@ -78,16 +69,10 @@ namespace ticcd::rational {
7869
// std::cout<<"get tolerance successfully"<<std::endl;
7970
//////////////////////////////////////////////////////////
8071
// TODO this should be the error of the whole mesh
81-
std::vector<Vector3> vlist;
82-
vlist.emplace_back(vertex_start);
83-
vlist.emplace_back(face_vertex0_start);
84-
vlist.emplace_back(face_vertex1_start);
85-
vlist.emplace_back(face_vertex2_start);
86-
87-
vlist.emplace_back(vertex_end);
88-
vlist.emplace_back(face_vertex0_end);
89-
vlist.emplace_back(face_vertex1_end);
90-
vlist.emplace_back(face_vertex2_end);
72+
std::vector<Vector3> vlist = {
73+
{vertex_start, face_vertex0_start, face_vertex1_start,
74+
face_vertex2_start, vertex_end, face_vertex0_end, face_vertex1_end,
75+
face_vertex2_end}};
9176

9277
bool use_ms = ms > 0;
9378
Array3 auto_err = get_numerical_error(vlist, false, use_ms);

0 commit comments

Comments
 (0)