Feature/risk tolerance risk level #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issues from a secure coding perspective. You might want to run this through a quality checker and linter as well. Did you want to write some unit tests for this as well? Test coverage is pretty low at the moment. |
nbuckwalt
reviewed
Aug 25, 2025
We should setup a quality checker and linter in the pipeline. I'll look at getting those added, probably not part of this PR though. and Yes i agree, the whole project is low on test coverage. I'll add that as a thing to do for the whole project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
building in some safeguards so if/when a customer decides to hook this up to their contrast data feed, they are aware of some risk that come with it. The formal acceptance risk tolerance will need to be set in the configuration along with the contrast configurations. The documentation is also updated to reflect these changes. This is a phase 1 approach to get something in the works for protection right now. big advancements around the configuration of these functions and what you may want to set the risk settings to be. For now, feel free to clone/change those risk settings, rebuild/deploy if needed.