Handle alarm actions to show error message

Author: georgweiss

app/alarm/model/src/main/java/org/phoebus/applications/alarm/client/AlarmClient.java

@@ -166,7 +166,7 @@ public void setMode(final boolean maintenance)
         {
             final String json = new String (JsonModelWriter.commandToBytes(cmd));
             final ProducerRecord<String, String> record = new ProducerRecord<>(command_topic, AlarmSystem.COMMAND_PREFIX + root.getPathName(), json);
-            producer.send(record);
+            producer.send(record).get();
         }
         catch (final Exception ex)
         {
@@ -182,7 +182,7 @@ public void setNotify(final boolean disable_notify)
         {
             final String json = new String (JsonModelWriter.commandToBytes(cmd));
             final ProducerRecord<String, String> record = new ProducerRecord<>(command_topic, AlarmSystem.COMMAND_PREFIX + root.getPathName(), json);
-            producer.send(record);
+            producer.send(record).get();
         }
         catch (final Exception ex)
         {
@@ -518,7 +518,7 @@ public void sendItemConfigurationUpdate(final String path, final AlarmTreeItem<?
     {
         final String json = new String(JsonModelWriter.toJsonBytes(config));
         final ProducerRecord<String, String> record = new ProducerRecord<>(config_topic, AlarmSystem.CONFIG_PREFIX + path, json);
-        producer.send(record);
+        producer.send(record).get();
     }
 
     /** Remove a component (and sub-items) from alarm tree
@@ -542,10 +542,10 @@ public void removeComponent(final AlarmTreeItem<?> item) throws Exception
             // The id message must arrive before the tombstone.
             final String json = new String(JsonModelWriter.deleteMessageToBytes());
             final ProducerRecord<String, String> id = new ProducerRecord<>(config_topic, AlarmSystem.CONFIG_PREFIX + item.getPathName(), json);
-            producer.send(id);
+            producer.send(id).get();
 
             final ProducerRecord<String, String> tombstone = new ProducerRecord<>(config_topic, AlarmSystem.CONFIG_PREFIX + item.getPathName(), null);
-            producer.send(tombstone);
+            producer.send(tombstone).get();
         }
         catch (Exception ex)
         {
@@ -563,7 +563,7 @@ public void acknowledge(final AlarmTreeItem<?> item, final boolean acknowledge)
             final String cmd = acknowledge ? "acknowledge" : "unacknowledge";
             final String json = new String (JsonModelWriter.commandToBytes(cmd));
             final ProducerRecord<String, String> record = new ProducerRecord<>(command_topic, AlarmSystem.COMMAND_PREFIX + item.getPathName(), json);
-            producer.send(record);
+            producer.send(record).get();
         }
         catch (final Exception ex)
         {

app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

@@ -15,6 +15,8 @@ public class Messages
 
     public static String acknowledgeFailed;
     public static String addComponentFailed;
+    public static String disableAlarmFailed;
+    public static String enableAlarmFailed;
     public static String moveItemFailed;
     public static String removeComponentFailed;
     public static String renameItemFailed;

app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/tree/EnableComponentAction.java

@@ -15,8 +15,10 @@
 import org.phoebus.applications.alarm.client.AlarmClientLeaf;
 import org.phoebus.applications.alarm.model.AlarmTreeItem;
 import org.phoebus.applications.alarm.ui.AlarmUI;
+import org.phoebus.applications.alarm.ui.Messages;
 import org.phoebus.framework.jobs.JobManager;
 import org.phoebus.ui.dialog.DialogHelper;
+import org.phoebus.ui.dialog.ExceptionDetailsErrorDialog;
 import org.phoebus.ui.javafx.ImageCache;
 
 import javafx.scene.Node;
@@ -84,7 +86,14 @@ public EnableComponentAction(final Node node, final AlarmClient model, final Lis
                 {
                     final AlarmClientLeaf copy = pv.createDetachedCopy();
                     if (copy.setEnabled(doEnable()))
-                        model.sendItemConfigurationUpdate(pv.getPathName(), copy);
+                        try {
+                            model.sendItemConfigurationUpdate(pv.getPathName(), copy);
+                        } catch (Exception e) {
+                            ExceptionDetailsErrorDialog.openError(Messages.error,
+                                    copy.isEnabled() ? Messages.enableAlarmFailed : Messages.disableAlarmFailed,
+                                    e);
+                            throw e;
+                        }
                 }
             });
         });

app/alarm/ui/src/main/resources/org/phoebus/applications/alarm/ui/messages.properties

@@ -20,6 +20,8 @@
 error=Error
 acknowledgeFailed=Failed to acknowledge alarm(s)
 addComponentFailed=Failed to add component
+disableAlarmFailed=Failed to disable alarm
+enableAlarmFailed=Failed to enable alarm
 moveItemFailed=Failed to move item
 removeComponentFailed=Failed to remove component
 renameItemFailed=Failed to rename item