Bug fix and cosmetic changes in save&restore search

Author: georgweiss

app/save-and-restore/app/src/main/java/org/phoebus/applications/saveandrestore/ui/ImageRepository.java

@@ -39,13 +39,13 @@ public class ImageRepository {
     public static final Image GOLDEN_SNAPSHOT =
             ImageCache.getImage(ImageRepository.class, "/icons/save-and-restore/snapshot-golden.png");
     public static final Image COMPOSITE_SNAPSHOT =
-            ImageCache.getImage(SearchWindowController.class, "/icons/save-and-restore/composite-snapshot.png");
+            ImageCache.getImage(ImageRepository.class, "/icons/save-and-restore/composite-snapshot.png");
     public static final Image EDIT_CONFIGURATION =
-            ImageCache.getImage(SearchWindowController.class, "/icons/save-and-restore/edit-configuration.png");
+            ImageCache.getImage(ImageRepository.class, "/icons/save-and-restore/edit-configuration.png");
 
     public static final Image SNAPSHOT_ADD_TAG_WITH_COMMENT =
-        ImageCache.getImage(SaveAndRestoreController.class, "/icons/save-and-restore/snapshot-add_tag.png");
+        ImageCache.getImage(ImageRepository.class, "/icons/save-and-restore/snapshot-add_tag.png");
 
     public static final Image SNAPSHOT_REMOVE_TAG_WITH_COMMENT =
-            ImageCache.getImage(SaveAndRestoreController.class, "/icons/save-and-restore/snapshot-remove_tag.png");
+            ImageCache.getImage(ImageRepository.class, "/icons/save-and-restore/snapshot-remove_tag.png");
 }

app/save-and-restore/app/src/main/java/org/phoebus/applications/saveandrestore/ui/search/FilterManagementController.java

@@ -56,15 +56,6 @@ public SearchAndFilterTab(SaveAndRestoreController saveAndRestoreController) {
                     return clazz.getConstructor(SaveAndRestoreController.class)
                             .newInstance(saveAndRestoreController);
                 }
-                else if(clazz.isAssignableFrom(SearchWindowController.class)){
-                    return clazz.getConstructor().newInstance();
-                }
-                else if(clazz.isAssignableFrom(FilterManagementController.class)){
-                    return clazz.getConstructor().newInstance();
-                }
-                else if(clazz.isAssignableFrom(SearchQueryEditorController.class)){
-                    return clazz.getConstructor().newInstance();
-                }
             } catch (Exception e) {
                 Logger.getLogger(SearchAndFilterTab.class.getName()).log(Level.SEVERE, "Failed to instantiate SearchAndFilterViewController", e);
             }