Skip to content

Commit 15c08bf

Browse files
committed
Remove Knob related code and examples
1 parent 1c957c3 commit 15c08bf

File tree

8 files changed

+1
-1063
lines changed

8 files changed

+1
-1063
lines changed

app/display/editor/src/main/resources/display_editor_preferences.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
# discourage adding them to new displays.
1212

1313
# Hiding widgets where representation has not been imported because of dependencies
14-
hidden_widget_types=linear-meter,knob,gauge,clock,digital_clock
14+
hidden_widget_types=linear-meter,gauge,clock,digital_clock
1515
#
1616
#
1717
# GUI Menu action Applications / Display / New Display opens the following template

app/display/model/src/main/java/org/csstudio/display/builder/model/BaseWidgetsService.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.csstudio.display.builder.model.widgets.EmbeddedDisplayWidget;
2626
import org.csstudio.display.builder.model.widgets.FileSelectorWidget;
2727
import org.csstudio.display.builder.model.widgets.GroupWidget;
28-
import org.csstudio.display.builder.model.widgets.KnobWidget;
2928
import org.csstudio.display.builder.model.widgets.LEDWidget;
3029
import org.csstudio.display.builder.model.widgets.LabelWidget;
3130
import org.csstudio.display.builder.model.widgets.MeterWidget;
@@ -82,7 +81,6 @@ public Collection<WidgetDescriptor> getWidgetDescriptors()
8281
FileSelectorWidget.WIDGET_DESCRIPTOR,
8382
GroupWidget.WIDGET_DESCRIPTOR,
8483
ImageWidget.WIDGET_DESCRIPTOR,
85-
KnobWidget.WIDGET_DESCRIPTOR,
8684
LabelWidget.WIDGET_DESCRIPTOR,
8785
LEDWidget.WIDGET_DESCRIPTOR,
8886
MeterWidget.WIDGET_DESCRIPTOR,

app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/KnobWidget.java

Lines changed: 0 additions & 405 deletions
This file was deleted.

app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ScaledSliderWidget.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ public class ScaledSliderWidget extends WritablePVWidget
6060
"Scaled Slider",
6161
"/icons/scaled_slider.png",
6262
"A scaled slider that can read/write a numeric PV",
63-
// Can also represent "org.csstudio.opibuilder.widgets.knob",
64-
// but using KnobWidget for that
6563
Arrays.asList("org.csstudio.opibuilder.widgets.scaledslider"))
6664
{
6765
@Override

app/display/model/src/main/resources/examples/01_main.bob

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -571,26 +571,6 @@ then press &lt;SPACE&gt; to activate button.</text>
571571
<height>26</height>
572572
<tooltip>$(actions)</tooltip>
573573
</widget>
574-
<widget type="action_button" version="3.0.0">
575-
<name>Action Button_33</name>
576-
<actions>
577-
<action type="open_display">
578-
<file>controls_knob.bob</file>
579-
<target>replace</target>
580-
<description>Knob</description>
581-
</action>
582-
</actions>
583-
<x>470</x>
584-
<y>440</y>
585-
<width>120</width>
586-
<height>26</height>
587-
<scripts>
588-
<script file="scripts/disable_missing.py">
589-
<pv_name>loc://knob("knob")</pv_name>
590-
</script>
591-
</scripts>
592-
<tooltip>$(actions)</tooltip>
593-
</widget>
594574
<widget type="action_button" version="3.0.0">
595575
<name>Action Button_34</name>
596576
<actions>

0 commit comments

Comments
 (0)