Skip to content

Commit 1cf6eed

Browse files
committed
Fix usage post refactoring.
1 parent 36d227b commit 1cf6eed

File tree

7 files changed

+128
-81
lines changed

7 files changed

+128
-81
lines changed

app/alarm/logging-ui/pom.xml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,25 @@
4343
<artifactId>jersey-client</artifactId>
4444
<version>1.19</version>
4545
</dependency>
46+
<dependency>
47+
<groupId>com.fasterxml.jackson.core</groupId>
48+
<artifactId>jackson-core</artifactId>
49+
<version>${jackson.version}</version>
50+
</dependency>
51+
<dependency>
52+
<groupId>com.fasterxml.jackson.core</groupId>
53+
<artifactId>jackson-annotations</artifactId>
54+
<version>${jackson.version}</version>
55+
</dependency>
56+
<dependency>
57+
<groupId>com.fasterxml.jackson.core</groupId>
58+
<artifactId>jackson-databind</artifactId>
59+
<version>${jackson.version}</version>
60+
</dependency>
61+
<dependency>
62+
<groupId>com.fasterxml.jackson.datatype</groupId>
63+
<artifactId>jackson-datatype-jsr310</artifactId>
64+
<version>${jackson.version}</version>
65+
</dependency>
4666
</dependencies>
4767
</project>

app/alarm/logging-ui/src/main/java/org/phoebus/applications/alarm/logging/ui/AlarmLogConfigSearchJob.java

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
package org.phoebus.applications.alarm.logging.ui;
22

3+
import com.fasterxml.jackson.core.JsonProcessingException;
4+
import com.fasterxml.jackson.core.type.TypeReference;
35
import com.fasterxml.jackson.databind.DeserializationFeature;
46
import com.fasterxml.jackson.databind.ObjectMapper;
57
import com.sun.jersey.api.client.WebResource;
6-
import org.phoebus.applications.alarm.messages.AlarmConfigMessage;
78
import org.phoebus.framework.jobs.Job;
89
import org.phoebus.framework.jobs.JobManager;
910
import org.phoebus.framework.jobs.JobRunnableWithCancel;
1011

12+
import javax.ws.rs.core.MediaType;
1113
import java.time.ZoneId;
1214
import java.time.format.DateTimeFormatter;
13-
import java.util.ArrayList;
1415
import java.util.List;
1516
import java.util.function.BiConsumer;
1617
import java.util.function.Consumer;
@@ -23,23 +24,23 @@ public class AlarmLogConfigSearchJob extends JobRunnableWithCancel {
2324
private final WebResource client;
2425
private final String pattern;
2526

26-
private final Consumer<List<AlarmConfigMessage>> alarmMessageHandler;
27+
private final Consumer<AlarmLogTableItem> alarmMessageHandler;
2728
private final BiConsumer<String, Exception> errorHandler;
2829

2930
private final ObjectMapper objectMapper;
3031
private DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss.SSS").withZone(ZoneId.of("UTC"));
3132

3233
public static Job submit(WebResource client,
3334
final String pattern,
34-
final Consumer<List<AlarmConfigMessage>> alarmMessageHandler,
35+
final Consumer<AlarmLogTableItem> alarmMessageHandler,
3536
final BiConsumer<String, Exception> errorHandler) {
3637
return JobManager.schedule("searching alarm log messages for : " + pattern,
3738
new AlarmLogConfigSearchJob(client, pattern, alarmMessageHandler, errorHandler));
3839
}
3940

4041
private AlarmLogConfigSearchJob(WebResource client,
4142
String pattern,
42-
Consumer<List<AlarmConfigMessage>> alarmMessageHandler,
43+
Consumer<AlarmLogTableItem> alarmMessageHandler,
4344
BiConsumer<String, Exception> errorHandler) {
4445
super();
4546
this.client = client;
@@ -58,9 +59,21 @@ public String getName() {
5859
@Override
5960
public Runnable getRunnable() {
6061
return () -> {
61-
List<String> result;
62-
List<AlarmConfigMessage> cResult = new ArrayList<>();
62+
AlarmLogTableApp.logger.info("searching for alarm log entires : " +
63+
"config: " + pattern);
6364

65+
try {
66+
List<AlarmLogTableItem> result = objectMapper
67+
.readValue(client.path("/search/alarm/config/"+pattern)
68+
.accept(MediaType.APPLICATION_JSON).get(String.class),
69+
new TypeReference<List<AlarmLogTableItem>>() {
70+
});
71+
if (result.size() >= 1) {
72+
alarmMessageHandler.accept(result.get(0));
73+
}
74+
} catch (JsonProcessingException e) {
75+
errorHandler.accept("Failed to search for alarm logs ", e);
76+
}
6477
};
6578
}
6679
}

app/alarm/logging-ui/src/main/java/org/phoebus/applications/alarm/logging/ui/AlarmLogSearchJob.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
public class AlarmLogSearchJob implements JobRunnable {
3232
private final Boolean isNodeTable;
3333
private final ObservableMap<Keys, String> searchParameters;
34-
private final Consumer<List<AlarmLogTableType>> alarmMessageHandler;
34+
private final Consumer<List<AlarmLogTableItem>> alarmMessageHandler;
3535
private final BiConsumer<String, Exception> errorHandler;
3636

3737
private final ObjectMapper objectMapper;
@@ -46,14 +46,14 @@ public static Job submit(WebResource client,
4646
final String pattern,
4747
Boolean isNodeTable,
4848
ObservableMap<Keys, String> searchParameters,
49-
final Consumer<List<AlarmLogTableType>> alarmMessageHandler,
49+
final Consumer<List<AlarmLogTableItem>> alarmMessageHandler,
5050
final BiConsumer<String, Exception> errorHandler) {
5151
return JobManager.schedule("searching alarm log messages for : " + pattern,
5252
new AlarmLogSearchJob(client, isNodeTable, searchParameters, alarmMessageHandler, errorHandler));
5353
}
5454

5555
private AlarmLogSearchJob(WebResource client, Boolean isNodeTable, ObservableMap<Keys, String> searchParameters,
56-
Consumer<List<AlarmLogTableType>> alarmMessageHandler, BiConsumer<String, Exception> errorHandler) {
56+
Consumer<List<AlarmLogTableItem>> alarmMessageHandler, BiConsumer<String, Exception> errorHandler) {
5757
super();
5858
this.client = client;
5959
this.isNodeTable = isNodeTable;
@@ -78,13 +78,13 @@ public void run(JobMonitor monitor) {
7878
map.putIfAbsent("size", Arrays.asList(String.valueOf(size)));
7979

8080
try {
81-
List<AlarmLogTableType> result = objectMapper.readValue(client.path("/search/alarm")
81+
List<AlarmLogTableItem> result = objectMapper.readValue(client.path("/search/alarm")
8282
.queryParams(map)
83-
.accept(MediaType.APPLICATION_JSON).get(String.class), new TypeReference<List<AlarmLogTableType>>() {
83+
.accept(MediaType.APPLICATION_JSON).get(String.class), new TypeReference<List<AlarmLogTableItem>>() {
8484
});
8585
alarmMessageHandler.accept(result);
8686
} catch (JsonProcessingException e) {
87-
e.printStackTrace();
87+
errorHandler.accept("Failed to search for alarm logs ", e);
8888
}
8989
}
9090
}

0 commit comments

Comments
 (0)