Skip to content

Commit 2401fd8

Browse files
authored
Merge pull request #3655 from lcaouen/Empty_name_Edit
add full path of the bob file as a tab name, if no name indicated
2 parents 123f629 + 4e0c31c commit 2401fd8

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

app/display/editor/src/main/java/org/csstudio/display/builder/editor/app/DisplayEditorInstance.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,15 @@ public class DisplayEditorInstance implements AppInstance
8080

8181
private final WidgetPropertyListener<String> model_name_listener = (property, old_value, new_value) ->
8282
{
83-
final String label = EditorUtil.isDisplayReadOnly(property.getWidget().checkDisplayModel())
84-
? "[R/O] " + property.getValue()
85-
: "[Edit] " + property.getValue();
83+
String fileName = property.getWidget().checkDisplayModel().getDisplayName();
84+
85+
String value = (property.getValue() == null || property.getValue().isEmpty())
86+
? fileName
87+
: property.getValue();
88+
89+
final String label = EditorUtil.isDisplayReadOnly(property.getWidget().checkDisplayModel())
90+
? "[R/O] " + value
91+
: "[Edit] " + value;
8692
Platform.runLater(() -> dock_item.setLabel(label));
8793
};
8894

app/display/model/src/main/java/org/csstudio/display/builder/model/DisplayModel.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,8 @@ public String getDisplayName()
173173
name = getUserData(USER_DATA_INPUT_FILE);
174174
if (name == null)
175175
name = "<No name>";
176+
else
177+
name= new java.io.File(name).getName();;
176178
}
177179
return name;
178180
}

app/display/model/src/main/resources/examples/initial.bob

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<display version="2.0.0">
3-
<name>Display</name>
3+
<name></name>
44
<widget type="label" version="2.0.0">
55
<name>Label</name>
66
<class>TITLE</class>

0 commit comments

Comments
 (0)