Revert "CSSTUDIO-3429 Call setTextFill(text_color) when square_led == false."

This reverts commit fce5f18.

Author: abrahamwolk

app/display/representation-javafx/src/main/java/org/csstudio/display/builder/representation/javafx/widgets/ByteMonitorRepresentation.java

@@ -428,25 +428,20 @@ public void updateChanges()
                 for (int i = 0; i < N; i++)
                 {
                     leds[i].setFill(save_values[i]);
-                    if (save_labels[i] != null) {
-                        if (square_led)
-                        {
-                            // Compare brightness of LED with text.
-                            final double brightness = Brightness.of(save_values[i]);
-                            if (Math.abs(text_brightness - brightness) < Brightness.SIMILARITY_THRESHOLD)
-                            {   // Colors of text and LED are very close in brightness.
-                                // Make text visible by forcing black resp. white
-                                if (brightness > Brightness.BRIGHT_THRESHOLD)
-                                    save_labels[i].setTextFill(Color.BLACK);
-                                else
-                                    save_labels[i].setTextFill(Color.WHITE);
-                            }
+                    if (save_labels[i] != null && square_led)
+                    {
+                        // Compare brightness of LED with text.
+                        final double brightness = Brightness.of(save_values[i]);
+                        if (Math.abs(text_brightness - brightness) < Brightness.SIMILARITY_THRESHOLD)
+                        {   // Colors of text and LED are very close in brightness.
+                            // Make text visible by forcing black resp. white
+                            if (brightness > Brightness.BRIGHT_THRESHOLD)
+                                save_labels[i].setTextFill(Color.BLACK);
                             else
-                                save_labels[i].setTextFill(text_color);
+                                save_labels[i].setTextFill(Color.WHITE);
                         }
-                        else {
+                        else
                             save_labels[i].setTextFill(text_color);
-                        }
                         save_labels[i].layout();
                     }
                 }