Skip to content

Commit 3b72b89

Browse files
committed
Need URL encoding in username/password when authenticating with native HttpClient
1 parent 119bd96 commit 3b72b89

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

app/save-and-restore/app/src/main/java/org/phoebus/applications/saveandrestore/client/SaveAndRestoreClientImpl.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,11 @@
3434
import java.net.CookieManager;
3535
import java.net.CookiePolicy;
3636
import java.net.URI;
37+
import java.net.URLEncoder;
3738
import java.net.http.HttpClient;
3839
import java.net.http.HttpRequest;
3940
import java.net.http.HttpResponse;
41+
import java.nio.charset.StandardCharsets;
4042
import java.time.Duration;
4143
import java.util.Base64;
4244
import java.util.List;
@@ -582,9 +584,9 @@ public List<Node> deleteTag(TagData tagData) {
582584
public UserData authenticate(String userName, String password) {
583585
String stringBuilder = Preferences.jmasarServiceUrl +
584586
"/login?username=" +
585-
userName +
587+
URLEncoder.encode(userName, StandardCharsets.UTF_8) +
586588
"&password=" +
587-
password;
589+
URLEncoder.encode(password, StandardCharsets.UTF_8);
588590
HttpRequest request = HttpRequest.newBuilder()
589591
.uri(URI.create(stringBuilder))
590592
.POST(HttpRequest.BodyPublishers.noBody())

0 commit comments

Comments
 (0)