Skip to content

Commit 462f291

Browse files
committed
move column visibility checks to a submenu #3608
1 parent d6e321e commit 462f291

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

core/ui/src/main/java/org/phoebus/ui/application/TableHelper.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import javafx.collections.ObservableList;
44
import javafx.scene.control.CheckMenuItem;
55
import javafx.scene.control.ContextMenu;
6+
import javafx.scene.control.Menu;
7+
import javafx.scene.control.MenuItem;
68
import javafx.scene.control.TableColumn;
79
import javafx.scene.control.TableView;
810
import org.phoebus.framework.persistence.Memento;
@@ -15,17 +17,19 @@ public class TableHelper {
1517
* */
1618
public static boolean addContextMenuColumnVisibilityEntries(final TableView<?> table, final ContextMenu menu) {
1719
boolean added_item = false;
20+
Menu visibilitySubMenu = new Menu("Column Visibility");
1821
for (TableColumn<?, ?> col : table.getColumns()) {
1922
if (col.getText().isEmpty()) continue;
2023
CheckMenuItem item = new CheckMenuItem("Show " + col.getText());
2124
item.selectedProperty().bindBidirectional(col.visibleProperty());
22-
menu.getItems().add(item);
25+
visibilitySubMenu.getItems().add(item);
2326
added_item = true;
2427
}
28+
if (added_item)
29+
menu.getItems().add(visibilitySubMenu);
2530
return added_item;
2631
}
2732

28-
2933
/** Save column visibilities to a memento
3034
* */
3135
public static <T> void saveColumnVisibilities(

0 commit comments

Comments
 (0)