CSSTUDIO-3420 Change type from LinkedList<> to ArrayList<> for 'pvNameToInstantToValue'.

Author: abrahamwolk

app/display/waterfallplot/src/main/java/org/phoebus/applications/waterfallplotwidget/WaterfallPlotController.java

@@ -336,7 +336,7 @@ public synchronized void redraw(WaterfallPlotRuntime.PVData pvData) {
                 }
             }
         } else if (pvData instanceof WaterfallPlotRuntime.ScalarPVsData scalarPVsData) {
-            LinkedList<Pair<String, ConcurrentSkipListMap<Instant, Double>>> pvNameToInstantToValue = scalarPVsData.pvNameToInstantToValue();
+            ArrayList<Pair<String, ConcurrentSkipListMap<Instant, Double>>> pvNameToInstantToValue = scalarPVsData.pvNameToInstantToValue();
             pvNameToInstantToValue.forEach(pvNameAndInstantToValueAtomicReference -> garbageCollectInstantToValue(pvNameAndInstantToValueAtomicReference.getValue(), t1));
 
             minFromPV = scalarPVsData.minFromPV().get();

app/display/waterfallplot/src/main/java/org/phoebus/applications/waterfallplotwidget/WaterfallPlotRuntime.java

@@ -62,7 +62,7 @@ public void initialize(WaterfallPlotWidget waterfallPlotWidget) {
         else {
             pvData = new ScalarPVsData(new AtomicDouble(Double.NaN),
                                        new AtomicDouble(Double.NaN),
-                                       new LinkedList<>());
+                                       new ArrayList<>());
         }
         retrieveHistoricValuesFromTheArchiver = waterfallPlotWidget.propRetrieveHistoricValuesFromTheArchiver().getValue();
         pvNames = waterfallPlotWidget.propInputPVs().getValue().stream().map(widgetProperty -> widgetProperty.getValue()).collect(Collectors.toUnmodifiableList());
@@ -75,7 +75,7 @@ public record WaveformPVData (AtomicDouble minFromPV,
                                   ConcurrentSkipListMap<Instant, ArrayList<Double>> instantToValue) implements PVData {}
     public record ScalarPVsData (AtomicDouble minFromPV,
                                  AtomicDouble maxFromPV,
-                                 LinkedList<Pair<String, ConcurrentSkipListMap<Instant, Double>>> pvNameToInstantToValue) implements PVData {}
+                                 ArrayList<Pair<String, ConcurrentSkipListMap<Instant, Double>>> pvNameToInstantToValue) implements PVData {}
 
     @Override
     public void start() {