clean simpleDateFormat declaration, and proposed date format in properties

Author: agaget

app/save-and-restore/app/src/main/java/org/phoebus/applications/saveandrestore/ui/snapshot/SnapshotController.java

@@ -289,14 +289,9 @@ private void takeSnapshot() {
                     List<TableEntry> tableEntries = createTableEntries(snapshots.get(0));
                     snapshotTable.updateTable(tableEntries, snapshots, showLiveReadbackProperty.get(), false, showDeltaPercentage);
 
-                    SimpleDateFormat formater = null;
-                    Date now = new Date();
-                    formater = new SimpleDateFormat("yy-MM-dd");
-                    String defaultTitle="";
                     if (!Preferences.default_title_snapshot_date_format.equals("")) {
-                            formater = new SimpleDateFormat(Preferences.default_title_snapshot_date_format);
-                            defaultTitle+=defaultTitle+formater.format(now);
-                            snapshotNameProperty.set(defaultTitle);
+                            SimpleDateFormat formater = new SimpleDateFormat(Preferences.default_title_snapshot_date_format);
+                            snapshotNameProperty.set(formater.format(new Date()));
                     }
 
                 })

app/save-and-restore/app/src/main/resources/save_and_restore_preferences.properties

@@ -23,4 +23,4 @@ search_result_page_size=30
 default_search_query=tags=golden
 
 # If declared add a date automatically in the name of the snapshot "Take Snapshot"
-#default_title_snapshot_date_format=YYYYMMHH_hhmmss
+#default_title_snapshot_date_format=yyyy-MM-dd HH:mm:ss