Set column names from externalized strings

Author: shroffk

app/channel/views/src/main/java/org/phoebus/channel/views/Messages.java

@@ -0,0 +1,33 @@
+/*******************************************************************************
+ * Copyright (c) 2010 Oak Ridge National Laboratory.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ ******************************************************************************/
+package org.phoebus.channel.views;
+
+import org.phoebus.framework.nls.NLS;
+
+/**
+ * String externalization
+ */
+public class Messages
+{
+    // ---
+    // --- Keep alphabetically sorted and 'in sync' with messages.properties!
+    // ---
+    /** Externalized strings */
+    public static String ChannelTableNameColumn;
+    public static String ChannelTableOwnerColumn;
+
+    static
+    {
+        NLS.initializeMessages(Messages.class);
+    }
+
+    private Messages()
+    {
+        // Prevent instantiation
+    }
+}

app/channel/views/src/main/java/org/phoebus/channel/views/ui/ChannelTableController.java

@@ -8,6 +8,7 @@
 import java.util.stream.Collectors;
 
 import org.phoebus.channel.views.ChannelTableApp;
+import org.phoebus.channel.views.Messages;
 import org.phoebus.channelfinder.Channel;
 import org.phoebus.channelfinder.ChannelUtil;
 import org.phoebus.channelfinder.Property;
@@ -92,10 +93,10 @@ public void initialize() {
         });
 
         tableView.getColumns().clear();
-        TableColumn<Channel, String> nameCol = new TableColumn<>("Name");
+        TableColumn<Channel, String> nameCol = new TableColumn<>(Messages.ChannelTableNameColumn);
         nameCol.setCellValueFactory(new PropertyValueFactory<Channel, String>("name"));
 
-        TableColumn<Channel, String> ownerCol = new TableColumn<>("Owner");
+        TableColumn<Channel, String> ownerCol = new TableColumn<>(Messages.ChannelTableOwnerColumn);
         ownerCol.setCellValueFactory(new PropertyValueFactory<Channel, String>("owner"));
         tableView.getColumns().addAll(nameCol, ownerCol);
 
@@ -196,9 +197,7 @@ public void createContextMenu() {
                 if (addTagJob != null) {
                     addTagJob.cancel();
                 }
-                List<String> channelNames = tableView.getSelectionModel().getSelectedItems().stream().map(ch -> {
-                    return ch.getName();
-                }).collect(Collectors.toList());
+                List<String> channelNames = tableView.getSelectionModel().getSelectedItems().stream().map(Channel::getName).collect(Collectors.toList());
                 AddTag2ChannelsJob.submit(getClient(),
                         channelNames,
                         tag,

app/channel/views/src/main/resources/org/phoebus/channel/views/messages.properties

@@ -0,0 +1,2 @@
+ChannelTableNameColumn=name
+ChannelTableOwnerColumn=owner