Skip to content

Commit 724d6e1

Browse files
author
kasemir
committed
PVA: Show 'echo12' sent and received
1 parent a5f3ec6 commit 724d6e1

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

core/pva/src/main/java/org/epics/pva/client/EchoHandler.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
/** Handle a server's ECHO reply
2121
* @author Kay Kasemir
2222
*/
23-
@SuppressWarnings("nls")
2423
class EchoHandler implements CommandHandler<ClientTCPHandler>
2524
{
2625
@Override
@@ -39,10 +38,10 @@ public void handleCommand(final ClientTCPHandler tcp, final ByteBuffer buffer) t
3938
buffer.get(payload);
4039
final String expected = tcp.getActiveEchoRequest();
4140
if (Arrays.equals(payload, expected.getBytes()))
42-
logger.log(Level.FINE, () -> "Received ECHO:\n" + Hexdump.toHexdump(payload));
41+
logger.log(Level.FINE, () -> "Received ECHO '" + expected + "'");
4342
else
4443
{
45-
logger.log(Level.WARNING, this + " received invalid echo reply, expected " + expected + ":\n" +
44+
logger.log(Level.WARNING, this + " received invalid echo reply, expected '" + expected + "':\n" +
4645
Hexdump.toHexdump(payload));
4746
return;
4847
}

core/pva/src/main/java/org/epics/pva/client/EchoRequest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
/** Send a 'ECHO' request to server
2020
* @author Kay Kasemir
2121
*/
22-
@SuppressWarnings("nls")
2322
class EchoRequest implements RequestEncoder
2423
{
2524
// Random number so replies don't all start with 'echo00'
@@ -40,7 +39,7 @@ public void encodeRequest(final byte version, final ByteBuffer buffer) throws Ex
4039
final int count = counter.incrementAndGet();
4140
active_check = String.format("echo%02d", count % 100);
4241
final byte[] check = active_check.getBytes();
43-
logger.log(Level.FINE, () -> "Sending ECHO request (Version " + version + ")");
42+
logger.log(Level.FINE, () -> "Sending ECHO request (Version " + version + " '" + active_check + "')");
4443
PVAHeader.encodeMessageHeader(buffer, PVAHeader.FLAG_NONE, PVAHeader.CMD_ECHO, check.length);
4544
buffer.put(check);
4645
}

0 commit comments

Comments
 (0)