Disallow login attempt if either username or password are not set

Author: georgweiss

app/credentials-management/src/main/java/org/phoebus/applications/credentialsmanagement/CredentialsManagementController.java

@@ -384,6 +384,16 @@ public void updateItem(StringProperty item, final boolean empty) {
                 textField.getStyleClass().add("text-field-styling");
                 textField.textProperty().bindBidirectional(getTableRow().getItem().username);
                 textField.disableProperty().bind(getTableRow().getItem().userLoggedIn);
+                ServiceItem serviceItem = getTableRow().getItem();
+                textField.setOnKeyPressed(keyEvent -> {
+                    if (keyEvent.getCode() == KeyCode.ENTER &&
+                            !serviceItem.username.isNull().get() &&
+                            !serviceItem.username.get().isEmpty() &&
+                            !serviceItem.password.isNull().get() &&
+                            !serviceItem.password.get().isEmpty()) {
+                        CredentialsManagementController.this.login(serviceItem);
+                    }
+                });
                 setGraphic(textField);
             }
         }
@@ -405,9 +415,14 @@ protected void updateItem(StringProperty item, final boolean empty) {
                 passwordField.setText(item.get() == null ? null : "dummypass"); // Hack to not reveal password length
                 passwordField.textProperty().bindBidirectional(getTableRow().getItem().password);
                 passwordField.disableProperty().bind(getTableRow().getItem().userLoggedIn);
+                ServiceItem serviceItem = getTableRow().getItem();
                 passwordField.setOnKeyPressed(keyEvent -> {
-                    if (keyEvent.getCode() == KeyCode.ENTER) {
-                        CredentialsManagementController.this.login(getTableRow().getItem());
+                    if (keyEvent.getCode() == KeyCode.ENTER &&
+                            !serviceItem.username.isNull().get() &&
+                            !serviceItem.username.get().isEmpty() &&
+                            !serviceItem.password.isNull().get() &&
+                            !serviceItem.password.get().isEmpty()) {
+                        CredentialsManagementController.this.login(serviceItem);
                     }
                 });
                 setGraphic(passwordField);