javadoc

Author: kasemir

core/pva/src/main/java/org/epics/pva/common/CertificateStatus.java

@@ -96,6 +96,7 @@ public boolean isValid()
         return "VALID".equals(status);
     }
 
+    /** PVAChannel connection handler, starts monitor */
     private void handleConnection(final PVAChannel channel, final ClientChannelState state)
     {
         if (state == ClientChannelState.CONNECTED)
@@ -109,6 +110,7 @@ private void handleConnection(final PVAChannel channel, final ClientChannelState
             }
     }
 
+    /** PVAChannel monitor handler, checks CERT:STATUS:... value */
     private void handleMonitor(final PVAChannel channel, final BitSet changes, final BitSet overruns, final PVAStructure data)
     {
         // Check overall status enum: VALID or UNKNOWN, PENDING, REVOKED, ...

core/pva/src/main/java/org/epics/pva/common/CertificateStatusMonitor.java

@@ -89,11 +89,11 @@ public static synchronized CertificateStatusMonitor instance()
     public synchronized CertificateStatus checkCertStatus(final TLSHandshakeInfo tls_info,final CertificateStatusListener listener)
     {
         if (!tls_info.status_pv_name.startsWith("CERT:STATUS:"))
-            throw new IllegalArgumentException("Need CERT:STATUS:... PV");
+            throw new IllegalArgumentException("Need CERT:STATUS:... PV, got " + tls_info.status_pv_name);
 
         logger.log(Level.FINER, () -> "Checking " + tls_info.status_pv_name + " for '" + tls_info.name + "'");
 
-        CertificateStatus cert_stat = certificate_states.computeIfAbsent(tls_info.status_pv_name,
+        final CertificateStatus cert_stat = certificate_states.computeIfAbsent(tls_info.status_pv_name,
                 stat_pv_name -> new CertificateStatus(client, tls_info.peer_cert, tls_info.status_pv_name));
         cert_stat.addListener(listener);