Check if msgIdStr is number before parsing to avoid exceptions in Elog client

wanglin86769 · wanglin86769 · commit 916f3ec4fa71 · 2025-05-13T14:11:04.000+08:00
diff --git a/app/logbook/elog/src/main/java/org/phoebus/elog/api/ElogApi.java b/app/logbook/elog/src/main/java/org/phoebus/elog/api/ElogApi.java
@@ -541,7 +541,10 @@ private long validateResponse( Response<String> resp ) throws LogbookException {
         } else {
           URI loc = URI.create( location );
           String[] path = loc.getPath().split("/");
-          msgId = Integer.parseInt( path[ path.length-1 ] );
+          String msgIdStr = path[ path.length-1 ];
+          if(msgIdStr != null && msgIdStr.matches("\\d+")) {
+            msgId = Integer.parseInt( msgIdStr );
+          }
         }
       }
       if( body.contains("form name=form1") || body.contains("type=password") ) {

Original file line number	Diff line number	Diff line change
`@@ -541,7 +541,10 @@ private long validateResponse( Response<String> resp ) throws LogbookException {`
`541`	`541`	`} else {`
`542`	`542`	`URI loc = URI.create( location );`
`543`	`543`	`String[] path = loc.getPath().split("/");`
`544`		`- msgId = Integer.parseInt( path[ path.length-1 ] );`
	`544`	`+ String msgIdStr = path[ path.length-1 ];`
	`545`	`+ if(msgIdStr != null && msgIdStr.matches("\\d+")) {`
	`546`	`+ msgId = Integer.parseInt( msgIdStr );`
	`547`	`+ }`
`545`	`548`	`}`
`546`	`549`	`}`
`547`	`550`	`if( body.contains("form name=form1") \|\| body.contains("type=password") ) {`