CSSTUDIO-1950 Remove call to fireItemDataConfigChanged() when archives are removed from instances of PVItem.

abrahamwolk · abrahamwolk · commit 91aa15daf6da · 2023-06-22T13:39:31.000+02:00
diff --git a/app/databrowser/src/main/java/org/csstudio/trends/databrowser3/model/PVItem.java b/app/databrowser/src/main/java/org/csstudio/trends/databrowser3/model/PVItem.java
@@ -243,19 +243,14 @@ public void addArchiveDataSource(final ArchiveDataSource archs[])
     public void removeArchiveDataSource(final ArchiveDataSource archive)
     {
         // Archive removed -> (Probably) no need to get new data
-        if (archives.remove(archive))
-            fireItemDataConfigChanged(false);
+        archives.remove(archive);
     }
 
     /** @param archs Archives to remove as a source from this item. Ignored when not used. */
     public void removeArchiveDataSource(final List<ArchiveDataSource> archs)
     {
-        boolean change = false;
         for (ArchiveDataSource archive : archs)
-            if (archives.remove(archive))
-                change = true;
-        if (change)
-            fireItemDataConfigChanged(false);
+            archives.remove(archive);
     }
 
     /** Replace existing archive data sources with given archives

Original file line number	Diff line number	Diff line change
`@@ -243,19 +243,14 @@ public void addArchiveDataSource(final ArchiveDataSource archs[])`
`243`	`243`	`public void removeArchiveDataSource(final ArchiveDataSource archive)`
`244`	`244`	`{`
`245`	`245`	`// Archive removed -> (Probably) no need to get new data`
`246`		`- if (archives.remove(archive))`
`247`		`- fireItemDataConfigChanged(false);`
	`246`	`+ archives.remove(archive);`
`248`	`247`	`}`
`249`	`248`
`250`	`249`	`/** @param archs Archives to remove as a source from this item. Ignored when not used. */`
`251`	`250`	`public void removeArchiveDataSource(final List<ArchiveDataSource> archs)`
`252`	`251`	`{`
`253`		`- boolean change = false;`
`254`	`252`	`for (ArchiveDataSource archive : archs)`
`255`		`- if (archives.remove(archive))`
`256`		`- change = true;`
`257`		`- if (change)`
`258`		`- fireItemDataConfigChanged(false);`
	`253`	`+ archives.remove(archive);`
`259`	`254`	`}`
`260`	`255`
`261`	`256`	`/** Replace existing archive data sources with given archives`