Show error dialog if search params are invalid

Author: georgweiss

app/logbook/olog/client-es/src/main/java/org/phoebus/olog/es/api/OlogHttpClient.java

@@ -260,9 +260,14 @@ private SearchResult findLogs(MultivaluedMap<String, String> searchParams) throw
                 .build();
         try {
             HttpResponse<String> response = httpClient.send(request, HttpResponse.BodyHandlers.ofString());
-            OlogSearchResult searchResult = OlogObjectMappers.logEntryDeserializer.readValue(response.body(), OlogSearchResult.class);
-            return SearchResult.of(new ArrayList<>(searchResult.getLogs()),
-                    searchResult.getHitCount());
+            if(response.statusCode() == 200) {
+                OlogSearchResult searchResult = OlogObjectMappers.logEntryDeserializer.readValue(response.body(), OlogSearchResult.class);
+                return SearchResult.of(new ArrayList<>(searchResult.getLogs()),
+                        searchResult.getHitCount());
+            }
+            else{
+                throw new RuntimeException(response.body());
+            }
         } catch (Exception e) {
             LOGGER.log(Level.WARNING, "failed to retrieve log entries", e);
             throw new RuntimeException(e);

app/logbook/olog/ui/src/main/java/org/phoebus/logbook/olog/ui/LogEntryCalenderViewController.java

@@ -34,6 +34,7 @@
 import org.phoebus.logbook.SearchResult;
 import org.phoebus.logbook.olog.ui.query.OlogQuery;
 import org.phoebus.logbook.olog.ui.query.OlogQueryManager;
+import org.phoebus.ui.dialog.ExceptionDetailsErrorDialog;
 
 import java.net.URL;
 import java.time.LocalDateTime;
@@ -262,7 +263,8 @@ public void search() {
                 },
                 (msg, ex) -> {
                     searchInProgress.set(false);
-                });
+                    ExceptionDetailsErrorDialog.openError(agenda, Messages.SearchFailed, "", ex);
+        });
     }
 
     public String getQuery() {

app/logbook/olog/ui/src/main/java/org/phoebus/logbook/olog/ui/LogEntryTableViewController.java

@@ -25,6 +25,7 @@
 import javafx.scene.control.Pagination;
 import javafx.scene.control.ProgressIndicator;
 import javafx.scene.control.SelectionMode;
+import javafx.scene.control.SplitPane;
 import javafx.scene.control.TableCell;
 import javafx.scene.control.TableColumn;
 import javafx.scene.control.TableView;
@@ -60,6 +61,7 @@
 import org.phoebus.security.store.SecureStore;
 import org.phoebus.security.tokens.ScopedAuthenticationToken;
 import org.phoebus.ui.dialog.DialogHelper;
+import org.phoebus.ui.dialog.ExceptionDetailsErrorDialog;
 
 import java.io.IOException;
 import java.util.ArrayList;
@@ -88,6 +90,10 @@ public class LogEntryTableViewController extends LogbookSearchController impleme
     @SuppressWarnings("unused")
     private GridPane viewSearchPane;
 
+    @SuppressWarnings("unused")
+    @FXML
+    private SplitPane splitPane;
+
     // elements related to the table view of the log entries
     @FXML
     @SuppressWarnings("unused")
@@ -420,6 +426,7 @@ public void search() {
                 },
                 (msg, ex) -> {
                     searchInProgress.set(false);
+                    ExceptionDetailsErrorDialog.openError(splitPane, Messages.SearchFailed, "", ex);
                 });
     }
 

app/logbook/olog/ui/src/main/java/org/phoebus/logbook/olog/ui/Messages.java

@@ -55,6 +55,7 @@ public class Messages
             PreviewOpenErrorTitle,
             ReplyToLogEntry,
             RequestTooLarge,
+            SearchFailed,
             SelectFile,
             SelectFolder,
             ShowHideDetails,

app/logbook/olog/ui/src/main/resources/org/phoebus/logbook/olog/ui/messages.properties

@@ -94,6 +94,7 @@ ScalingFactor=Scaling Factor
 SearchButtonText=Search:
 Search=Search available:
 SearchAvailableItems=Search the list of available items.
+SearchFailed=Search Failed
 SearchToolTip=Edit and press Enter to search
 Selected=Selected
 SelectFolder=Select Folder