Skip to content

Commit f9741b1

Browse files
committed
CSSTUDIO-2964 Replace calls to padWithLeadingZero() with calls to DateTimeFormatter.format().
1 parent 9970970 commit f9741b1

File tree

1 file changed

+7
-21
lines changed

1 file changed

+7
-21
lines changed

app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/tree/AlarmTreeViewCell.java

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.phoebus.applications.alarm.ui.Messages;
2626

2727
import java.time.LocalDateTime;
28+
import java.time.format.DateTimeFormatter;
2829
import java.util.LinkedList;
2930
import java.util.List;
3031
import java.util.Optional;
@@ -110,18 +111,18 @@ protected void updateItem(final AlarmTreeItem<?> item, final boolean empty)
110111
} else {
111112
if (leaf.getEnabled().enabled_date != null) {
112113
LocalDateTime enabledDate = leaf.getEnabled().enabled_date;
113-
String stringToAppend = padWithLeadingZero(enabledDate.getHour()) + ":" + padWithLeadingZero(enabledDate.getMinute()) + ":" + padWithLeadingZero(enabledDate.getSecond());
114+
String enabledDateString;
114115

115116
LocalDateTime now = LocalDateTime.now();
116117
if (!(now.getDayOfMonth() == enabledDate.getDayOfMonth() &&
117118
now.getMonthValue() == enabledDate.getMonthValue() &&
118119
now.getYear() == enabledDate.getYear())) {
119-
String paddedMonthNumber = padWithLeadingZero(enabledDate.getMonthValue());
120-
String paddedDayNumber = padWithLeadingZero(enabledDate.getDayOfMonth());
121-
stringToAppend = enabledDate.getYear() + "-" + paddedMonthNumber + "-" + paddedDayNumber + "T" + stringToAppend;
120+
enabledDateString = DateTimeFormatter.ISO_LOCAL_DATE_TIME.format(enabledDate);
122121
}
123-
124-
disabledTimerIndicator.setText("(" + Messages.disabledUntil + " " + stringToAppend + ")");
122+
else {
123+
enabledDateString = DateTimeFormatter.ISO_LOCAL_TIME.format(enabledDate);
124+
}
125+
disabledTimerIndicator.setText("(" + Messages.disabledUntil + " " + enabledDateString + ")");
125126
} else {
126127
disabledTimerIndicator.setText("(" + Messages.disabled + ")");
127128
}
@@ -181,21 +182,6 @@ else if (leavesDisabledStatusBooleanPair.getKey().equals(LeavesDisabledStatus.So
181182
}
182183
}
183184

184-
private String padWithLeadingZero(int n) {
185-
if (n < 0) {
186-
throw new RuntimeException("Argument must be greater or equal to zero.");
187-
}
188-
else if (n <= 9) {
189-
return "0" + n;
190-
}
191-
else if (n <= 99) {
192-
return Integer.toString(n);
193-
}
194-
else {
195-
throw new RuntimeException("Argument must be less than 100");
196-
}
197-
}
198-
199185
private boolean isLeafDisabled(AlarmClientLeaf alarmClientLeaf) {
200186
return !alarmClientLeaf.isEnabled() || alarmClientLeaf.getState().isDynamicallyDisabled();
201187
}

0 commit comments

Comments
 (0)