New keyboard shortcut Ctrl + Shift + S for "Save As..."?

[abrahamwolk]

Ctrl + S is currently a keyboard shortcut for "Save". Would it make sense to also add the keyboard shortcut Ctrl + Shift + S for "Save As..."? It could be added to the Display Builder and to the Data Browser.

It is a standard shortcut in many applications.

[kasemir]

Sure, just note that Mac OS uses "Command S" for save, and "Command Shift S" for save-as.

So would need to change the exact key combination similar to

phoebus/core/ui/src/main/java/org/phoebus/ui/application/PhoebusApplication.java

Lines 226 to 228 in 7e26b3c

	public static KeyCombination closeAllTabsKeyCombination = PlatformInfo.is_mac_os_x ?
	new KeyCodeCombination(KeyCode.W, KeyCombination.SHIFT_DOWN, KeyCodeCombination.SHORTCUT_DOWN) :
	new KeyCodeCombination(KeyCode.F4, KeyCombination.SHIFT_DOWN, KeyCombination.CONTROL_DOWN);

[kasemir]

I'm actually not sure where the "Ctrl S" is currently mapped. It might not be in the data browser, display builder, scan editor, ... but at a higher level in core-ui, allowing to "save" any DockItemWithInput that isDirty or isSaveAsSupported

[abrahamwolk]

Thank you for the information! I will go ahead and implement the Ctrl/Command + Shift + S functionality then.