Tidy logging and unnecessary lattice node code

Author: mikera

convex-peer/src/main/java/convex/node/LatticePropagator.java

@@ -92,11 +92,6 @@ public class LatticePropagator<V extends ACell> implements Closeable {
 	 */
 	private volatile boolean running = false;
 
-	/**
-	 * Flag indicating if a broadcast is currently in progress
-	 */
-	private final AtomicBoolean broadcasting = new AtomicBoolean(false);
-
 	/**
 	 * Queue for receiving broadcast trigger notifications.
 	 * Uses LatestUpdateQueue which only stores the most recent trigger,
@@ -167,7 +162,7 @@ public synchronized void start() {
 		propagationThread.setDaemon(true);
 		propagationThread.start();
 
-		log.info("LatticePropagator started for NodeServer on port {}", nodeServer.getPort());
+		log.debug("LatticePropagator started for NodeServer on port {}", nodeServer.getPort());
 	}
 
 	/**
@@ -213,7 +208,7 @@ private void propagationLoop() {
 			}
 		} finally {
 			Stores.setCurrent(savedStore);
-			log.info("LatticePropagator stopped");
+			log.debug("LatticePropagator stopped");
 		}
 	}
 
@@ -251,47 +246,35 @@ private void sendDeltaIfReady(V value, long currentTime) {
 			return;
 		}
 
-		// Set broadcasting flag
-		if (!broadcasting.compareAndSet(false, true)) {
-			// Already broadcasting, skip
-			log.trace("Already broadcasting, skipping");
-			return;
-		}
-
-		try {
-			// Send delta broadcasts in a loop until no more changes
-			do {
-				try {
-					broadcast(value);
-					lastAnnouncedValue = value;
-					lastBroadcastTime = currentTime;
-					broadcastCount++;
-					log.debug("Delta broadcast sent (count: {})", broadcastCount);
-
-					// After broadcast, check if value changed again
-					value = nodeServer.getLocalValue();
-					currentTime = Utils.getCurrentTimestamp();
-
-					// Poll queue to consume any trigger (LatestUpdateQueue only stores 1 item)
-					triggerQueue.poll();
-
-					// If value changed, continue broadcasting
-					if (!hasValueChanged(value)) {
-						break; // No more changes, exit loop
-					}
+		// Send delta broadcasts in a loop until no more changes
+		do {
+			try {
+				broadcast(value);
+				lastAnnouncedValue = value;
+				lastBroadcastTime = currentTime;
+				broadcastCount++;
+				log.debug("Delta broadcast sent (count: {})", broadcastCount);
+
+				// After broadcast, check if value changed again
+				value = nodeServer.getLocalValue();
+				currentTime = Utils.getCurrentTimestamp();
+
+				// Poll queue to consume any trigger (LatestUpdateQueue only stores 1 item)
+				triggerQueue.poll();
+
+				// If value changed, continue broadcasting
+				if (!hasValueChanged(value)) {
+					break; // No more changes, exit loop
+				}
 
-					log.debug("Value changed during broadcast, sending another delta");
+				log.debug("Value changed during broadcast, sending another delta");
 
-				} catch (IOException e) {
-					log.warn("Error during lattice broadcast", e);
-					break;
-				}
-			} while (running && !Thread.currentThread().isInterrupted());
+			} catch (IOException e) {
+				log.warn("Error during lattice broadcast", e);
+				break;
+			}
+		} while (running && !Thread.currentThread().isInterrupted());
 
-		} finally {
-			// Clear broadcasting flag
-			broadcasting.set(false);
-		}
 	}
 
 	/**
@@ -491,15 +474,6 @@ public boolean isRunning() {
 		return running;
 	}
 
-	/**
-	 * Checks if a broadcast is currently in progress.
-	 *
-	 * @return true if broadcasting, false otherwise
-	 */
-	public boolean isBroadcasting() {
-		return broadcasting.get();
-	}
-
 	/**
 	 * Gets the number of broadcasts sent by this propagator.
 	 *
@@ -575,7 +549,7 @@ public void close() {
 			}
 		}
 
-		log.info("LatticePropagator stopped (sent {} delta broadcasts, {} root syncs)",
+		log.debug("LatticePropagator stopped (sent {} delta broadcasts, {} root syncs)",
 			broadcastCount, rootSyncCount);
 	}
 }

convex-peer/src/main/java/convex/node/NodeServer.java

@@ -142,7 +142,7 @@ public void launch() throws IOException, InterruptedException {
 			throw new IllegalStateException("NodeServer is already running");
 		}
 
-		log.info("Launching NodeServer on port {}", port);
+		log.debug("Launching NodeServer on port {}", port);
 
 		// Create Netty server if not already created
 		if (networkServer == null) {
@@ -164,7 +164,7 @@ public void launch() throws IOException, InterruptedException {
 		propagator = new LatticePropagator<>(this, store);
 		propagator.start();
 
-		log.info("NodeServer started successfully on port {}", port);
+		log.debug("NodeServer started successfully on port {}", port);
 	}
 
 	/**
@@ -907,7 +907,7 @@ public void close() throws IOException {
 			return;
 		}
 
-		log.info("Closing NodeServer");
+		log.trace("Closing NodeServer");
 
 		running = false;
 
@@ -925,7 +925,7 @@ public void close() throws IOException {
 			if (peer != null) {
 				try {
 					peer.close();
-					log.debug("Closed peer connection: {}", peer.getHostAddress());
+					log.trace("Closed peer connection: {}", peer.getHostAddress());
 				} catch (Exception e) {
 					log.warn("Error closing peer connection: {}", peer.getHostAddress(), e);
 				}