Skip to content

Commit 0fead9f

Browse files
committed
Retry mecanism improvement, adding kind of error in logs
1 parent 4bdb23f commit 0fead9f

File tree

1 file changed

+13
-18
lines changed
  • packages/serverless-offline-kinesis/src

1 file changed

+13
-18
lines changed

packages/serverless-offline-kinesis/src/index.js

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,6 @@ const LambdaContext = require('serverless-offline/src/LambdaContext');
2828
const NO_KINESIS_FOUND = 'Could not find kinesis stream';
2929
const KINESIS_RETRY_DELAY = 2000;
3030

31-
const fromCallback = fun =>
32-
new Promise((resolve, reject) => {
33-
fun((err, data) => {
34-
if (err) return reject(err);
35-
resolve(data);
36-
});
37-
});
38-
3931
const printBlankLine = () => console.log();
4032

4133
const extractStreamNameFromARN = arn => {
@@ -160,17 +152,20 @@ class ServerlessOfflineKinesis {
160152

161153
this.serverless.cli.log(`${streamName}`);
162154

163-
const kinesisStream = await fromCallback(cb =>
164-
client.describeStream(
165-
{
166-
StreamName: streamName
167-
},
168-
cb
169-
)
170-
).catch(err => null);
171-
if (!kinesisStream) {
155+
const kinesisStream = await client
156+
.describeStream({
157+
StreamName: streamName
158+
})
159+
.promise()
160+
.catch(err => err);
161+
162+
if (kinesisStream instanceof Error) {
172163
if (retry) {
173-
this.serverless.cli.log(`${streamName} - not Found, retrying in ${KINESIS_RETRY_DELAY}ms`);
164+
this.serverless.cli.log(
165+
`${streamName} - not found because of ${
166+
kinesisStream.code
167+
}, retrying in ${KINESIS_RETRY_DELAY}ms`
168+
);
174169
setTimeout(
175170
this.createKinesisReadable.bind(this),
176171
KINESIS_RETRY_DELAY,

0 commit comments

Comments
 (0)