ssm-provider doesnt throw error if file doesnt exist

Author: godu

packages/serverless-offline-ssm-provider/README.md

@@ -23,5 +23,5 @@ plugins:
 ```yml
 custom:
   serverless-offline-ssm-provider:
-    file: .env
+    file: .ssm
 ```

packages/serverless-offline-ssm-provider/src/index.js

@@ -1,15 +1,27 @@
 const fs = require('fs');
-
-const getValues = (path = '.env') =>
-  fs
-    .readFileSync(path, {encoding: 'utf-8'})
-    .trim()
-    .split('\n')
-    .map(line => line.split(/=(.*)/))
-    .reduce((acc, [key, value]) => {
-      acc[key] = value;
-      return acc;
-    }, {});
+const {fromPairs, get, map, pipe, split, trim} = require('lodash/fp');
+
+const fromCallback = fun => (...args) =>
+  new Promise((resolve, reject) =>
+    fun(...args, (err, data) => (err ? reject(err) : resolve(data)))
+  );
+const readFile = fromCallback(fs.readFile);
+
+const getValues = (path = '.ssm') => {
+  const values = (async () => {
+    try {
+      return pipe(
+        trim,
+        split('\n'),
+        map(split(/=(.*)/)),
+        fromPairs
+      )(await readFile(path, {encoding: 'utf-8'}));
+    } catch (err) {
+      return null;
+    }
+  })();
+  return key => values.then(get(key));
+};
 
 class ServerlessOfflineSSMProvider {
   constructor(serverless) {
@@ -24,17 +36,17 @@ class ServerlessOfflineSSMProvider {
       if (service !== 'SSM' || method !== 'getParameter')
         return request(service, method, params, options);
 
-      return request(service, method, params, options).catch(error => {
+      return request(service, method, params, options).catch(async error => {
         const {Name} = params;
-        const Value = this.values[Name];
+        const Value = await this.values(Name);
 
-        if (!Value) return Promise.reject(error);
+        if (!Value) throw error;
 
-        return Promise.resolve({
+        return {
           Parameter: {
             Value
           }
-        });
+        };
       });
     };
 

tests/serverless-plugins-integration/.ssm

@@ -0,0 +1,3 @@
+/sqs/port=9324
+/dynamodb/port=8000
+/kinesis/port=4567

tests/serverless-plugins-integration/custom.yml

@@ -0,0 +1,18 @@
+serverless-offline-sqs:
+  endpoint: http://0.0.0.0:${ssm:/sqs/port}
+  region: ${self:provider.region}
+  accessKeyId: root
+  secretAccessKey: root
+  skipCacheInvalidation: false
+serverless-offline-dynamodb-streams:
+  endpoint: http://0.0.0.0:${ssm:/dynamodb/port}
+  region: ${self:provider.region}
+  accessKeyId: root
+  secretAccessKey: root
+  skipCacheInvalidation: false
+serverless-offline-kinesis:
+  endpoint: http://0.0.0.0:${ssm:/kinesis/port}
+  region: ${self:provider.region}
+  accessKeyId: root
+  secretAccessKey: root
+  skipCacheInvalidation: false

tests/serverless-plugins-integration/package.json

@@ -17,11 +17,12 @@
     "aws-sdk": "^2.538.0",
     "figures": "^3.0.0",
     "lodash": "^4.17.15",
-    "serverless": "^1.53.0",
-    "serverless-offline": "^5.11.0",
     "serverless-offline-dynamodb-streams": "^2.0.0",
     "serverless-offline-kinesis": "^2.0.0",
     "serverless-offline-sqs": "^2.0.3",
+    "serverless-offline-ssm-provider": "^1.0.5",
+    "serverless-offline": "^5.11.0",
+    "serverless": "^1.53.0",
     "signal-exit": "^3.0.2"
   }
 }

tests/serverless-plugins-integration/serverless.dynamodb-stream.yml

@@ -8,6 +8,7 @@ provider:
 plugins:
   localPath: '../../packages'
   modules:
+    - serverless-offline-ssm-provider
     - serverless-offline-dynamodb-streams
     - serverless-offline
 
@@ -61,9 +62,4 @@ resources:
 custom:
   serverless-offline:
     port: 3443
-  serverless-offline-dynamodb-streams:
-    endpoint: http://0.0.0.0:8000
-    region: ${self:provider.region}
-    accessKeyId: root
-    secretAccessKey: root
-    skipCacheInvalidation: false
+  serverless-offline-dynamodb-streams: ${file(./custom.yml):serverless-offline-dynamodb-streams}

tests/serverless-plugins-integration/serverless.kinesis.yml

@@ -8,6 +8,7 @@ provider:
 plugins:
   localPath: '../../packages'
   modules:
+    - serverless-offline-ssm-provider
     - serverless-offline-kinesis
     - serverless-offline
 
@@ -51,9 +52,4 @@ resources:
 custom:
   serverless-offline:
     port: 3223
-  serverless-offline-kinesis:
-    endpoint: http://0.0.0.0:4567
-    region: ${self:provider.region}
-    accessKeyId: root
-    secretAccessKey: root
-    skipCacheInvalidation: false
+  serverless-offline-kinesis: ${file(./custom.yml):serverless-offline-kinesis}

tests/serverless-plugins-integration/serverless.sqs.yml

@@ -8,6 +8,7 @@ provider:
 plugins:
   localPath: '../../packages'
   modules:
+    - serverless-offline-ssm-provider
     - serverless-offline-sqs
     - serverless-offline
 
@@ -47,9 +48,4 @@ resources:
 custom:
   serverless-offline:
     port: 3333
-  serverless-offline-sqs:
-    endpoint: http://0.0.0.0:9324
-    region: ${self:provider.region}
-    accessKeyId: root
-    secretAccessKey: root
-    skipCacheInvalidation: false
+  serverless-offline-sqs: ${file(./custom.yml):serverless-offline-sqs}