Fixed possible crash when user-space destructs the context when handling a tcp response

Author: EmielBruijntjes

Makefile

@@ -3,7 +3,7 @@ INCLUDE_DIR             = ${PREFIX}/include
 LIBRARY_DIR             = ${PREFIX}/lib
 export LIBRARY_NAME		= dnscpp
 export SONAME			= 1.3
-export VERSION			= 1.3.4
+export VERSION			= 1.3.5
 
 all:
 		$(MAKE) -C src all

src/sockets.cpp

@@ -107,7 +107,16 @@ size_t Sockets::deliver(size_t maxcalls)
     // when responses from tcp sockets are delivered, it is possible that at the same
     // time those sockets are removed from the underlying array (by the onUnused() method),
     // to ensure that we can use a simple iterator, we make a copy of the sockets
-    auto sockets = _tcps;
+    // (note that the Tcp object has smarty detection of user-space destruction, so we
+    // cannot make a normal copy of the shared_ptr<Tcp> here, as that would keep the
+    // object in space)
+    std::vector<Tcp*> sockets;
+    
+    // micro-optimization
+    sockets.reserve(_tcps.size());
+    
+    // copy them one at a time
+    for (const auto &socket : _tcps) sockets.push_back(socket.get());
 
     // deliver the buffer from all tcp sockets
     for (auto &socket : sockets)